Hello triangle sample: Replace deprecated debug reports extension, fix validation and clean up code #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix validation layers not being enabled in debug builds Refs KhronosGroup#1168
SaschaWillems
changed the title
Use extension name constants instead of strings Remove unnecessary arguments
SaschaWillems
changed the title
SaschaWillems
changed the title
The teardown function was only used for that anyway and was unnecessary
…plicate queue idle wait Add comments, throw if no device is found Males code easier to follow
asuessenbach
approved these changes
Oct 22, 2024
gpx1000
approved these changes
Nov 8, 2024
gary-sweet
approved these changes
Nov 11, 2024
|
3 approvals - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The hello triangle sample has been using the debug report extension for validation, which has been deprecated years ago. This PR replaces that with the debug utils extension. It also fixes an issue where validation layers weren't enabled in debug builds unless explicitly requested via the VKB_VALIDATION_LAYERS cmake option. It also fixes some minor things like wrong/misleading error messges and does some general code cleanup like removing unnecessary variables and arguments.
This fixes one of the issues of that sample documented in #1168
General Checklist:
Please ensure the following points are checked:
Note: The Samples CI runs a number of checks including: