Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shading_language_selection.cpp #1260

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

RobertHenry6bev
Copy link

Fix typo in a LOGI message

Description

Fix typo

I have done no testing. I only see this typo in one place.

Fix typo in a LOGI message
@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ SaschaWillems
❌ RobertHenry6bev
You have signed the CLA already but the status is still pending? Let us recheck it.

asuessenbach
asuessenbach previously approved these changes Jan 16, 2025
@SaschaWillems
Copy link
Collaborator

@RobertHenry6bev This fails at CI. You need to update the copyright of the file(s) you changed.

@marty-johnson59
Copy link
Contributor

Hi @RobertHenry6bev, it looks like you need to sign the CLA before we can merge this. LMK if questions on how to do that. Thanks.

@RobertHenry6bev
Copy link
Author

As far as I remember, I have never done this before. (The overhead is a little high for a small change, but, ok).

So I vist https://cla-assistant.io/my-cla and after granting the assistant all the permissions it asks for, am led to a web page that says (with my hand edits to insert table col separators '|':

Status Repository CLA Date of Signature
OK | KhronosGroup / Vulkan-Samples | Khronos Open Source Contributor License Agreement | January 15, 2025

Is this sufficient?
You have my permission to make the changes yourself. I was merely trying to be a good citizen to fix something my "proofreader's eye" caught.
I recently retired from 40 years in CS/engineering, and so do not have to bow to my corporate lawyers.

@marty-johnson59
Copy link
Contributor

Thanks. Yah, does seem like overkill for such a small change, but the tools are strict on licensing around here.. Looks like there's a merge conflict now (hopefully easy to resolve?). If this is too much of a pain, just LMK - we're happy to do this tweak ourselves too:)

@RobertHenry6bev
Copy link
Author

Yah, this is too much of a pain for me right now. I would appreciate it if you closed this PR and then applied the changes yourself. Thank you very much!

@marty-johnson59
Copy link
Contributor

Sounds good. We'll take care of it. Thanks for pointing this out to us - very much appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants