Skip to content

Add GATEWAY_IP6 variable #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add GATEWAY_IP6 variable #10

wants to merge 1 commit into from

Conversation

DanWin
Copy link

@DanWin DanWin commented Oct 31, 2024

This pull request adds an IPv6 gateway configuration variable

Mandatory Checklist

  • Legal agreements accepted. By contributing to this organisation, you acknowledge you have read, understood, and agree to be bound by these these agreements:

Terms of Service, Privacy Policy, Cookie Policy, E-Sign Consent, DMCA, Imprint

Optional Checklist

The following items are optional but might be requested in certain cases.

  • I have tested it locally
  • I have reviewed and updated any documentation if relevant
  • I am providing new code and test(s) for it

@ArrayBolt3
Copy link
Contributor

Everything here looks correct to me. Will try to work on testing this and the other PRs soon.

Comment on lines 14 to +15
GATEWAY_IP=\"$GATEWAY_IP\"
GATEWAY_IP6=\"$GATEWAY_IP6\"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This slightly scares me because IPv6 addresses have [, ], and : characters in them, all of which can be treated specially by the shell in some contexts. Could we use some extra quotes to make sure nothing goes awry here? (The GATEWAY_IP variable doesn't strictly need them, but maybe we could add them there for consistency too.)

Suggested change
GATEWAY_IP=\"$GATEWAY_IP\"
GATEWAY_IP6=\"$GATEWAY_IP6\"
GATEWAY_IP="\"$GATEWAY_IP\""
GATEWAY_IP6="\"$GATEWAY_IP6\""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants