-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility method to format dictionary #65
Add utility method to format dictionary #65
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @DhruvDuseja ! It looks like tests are passing so this is close to ready. I have two minor changes to request (see comments), and then feel free to remove WIP status and I think it'll be good to merge.
Thanks for the feedback @rkingsbury. I've made the changes in the doc and added the test. Please let me know if this looks good. Hopefully, the doc reads better now but please let me know if there are any changes needed there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made some minor comments on the docstring. The last thing I request is that you please update the changelog. This will be the first change after the last release, so you can add a new section (following the Keep a Changelog format) like this:
## [Unreleased]
### Added
-
Please take out of WIP status when you're ready, and I'll be happy to merge.
Thanks @rkingsbury. I've made the required changes, hope this looks good! |
Closes #65 Thanks @DhruvDuseja ! |
Summary
Major changes:
format_solute
to format a solute dictionary with the provided unit. (Closes add utility function to format dict with single unit #53)Todos
If this is work in progress, what else needs to be done?
Checklist
ruff
. (For guidance in fixing rule violates, see rule list)mypy
.Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: