-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dry run option #46
Conversation
As I said in the related issue, I don't really like global flags that alter behavior of the whole program and turn it into something else. Especially when they are implemented the way you did it - this "dryRun" option seems like a corruption, which has spread throughout the codebase and spoiled every part of it. I currently work on a lot of updates for mc-publish, which includes cleaning up and refactoring my code. Sadly, this solution is quite opposite of what I'm trying to achieve. I can think of a way to implement such feature without ravaging the entire project (e.g. by proxying And about other things. b79decb has nothing to do with the original goal of this PR, while being a massive and breaking change on its own, so it definitely shouldn't be included here. I'm working on glueing While I deeply appreciate your enthusiasm and desire to help, some things must be reverted and others should be reworked. A couple of tips for future PRs:
I see that you have put quite some work and thought in these changes, but they just don't fit the project the way they are now, so it's easier to start fresh with them. Sadly, with my heart bleeding I need to press that red button under my message and reject the PR. But I still greatly appreciate the try to make this action better! |
|
That's why you shouldn't trust anybody on Discord :D
So, throwing a personal key into the public domain breaches an agreement between user and CurseForge. Anyway, distribution of any API key is meaningless at best and absolutely disastrous at worst. Therefore, the rule of thumb here is - if you are about to commit one for everyone to see, you're doing something wrong, so you need to review your current approach. |
closes #45