Prevent length constraint creation on endAbsolute lines #5938
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5938 +/- ##
==========================================
+ Coverage 85.84% 85.90% +0.05%
==========================================
Files 113 113
Lines 44484 44511 +27
==========================================
+ Hits 38187 38236 +49
+ Misses 6297 6275 -22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…t-creation-on-endAbsolute-lines
pierremtb
changed the title
src/clientSideScene/segments.ts
Outdated
| if (hasEndAbsolute) { | ||
| // Won't be able to constrain that length | ||
| toast.error( | ||
| 'Unable to constraint the length of a segment with endAbsolute' |
There was a problem hiding this comment.
@Irev-Dev I'm curious about your opinion on this. Been looking for a way to intercept the call to set the length constraint on segments that can't actually take it like the endAbsolute ones, but super open to suggestions on different paths forward. Then I'm good to add a test for this of course!
There was a problem hiding this comment.
Looks like a good solution for now to me, but all good if you want to hear from @Irev-Dev before merging!
Thanks @franknoirot Co-authored-by: Frank Noirot <[email protected]>
Fixes #5937 and #5871
Screen.Recording.2025-03-21.at.2.45.12.PM.mov