Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMP: Streamline client project integration by explicitly including "vector" #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Nov 1, 2022

This commit fixes regression introduced in b99fa73 (Add several functions to the render window) allowing client project to successfully build without having to include "vector" header.

…vector"

This commit fixes regression introduced in b99fa73 (Add several functions
to the render window) allowing client project to successfully build
without having to include "vector" header.
@jcfr jcfr requested a review from psavery November 1, 2022 04:38
@aylward
Copy link
Contributor

aylward commented Nov 1, 2022

Re-running failed test (Linux wheels).

@jcfr
Copy link
Member Author

jcfr commented Nov 1, 2022

Error is the following:

        CMake Error at /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
          Could NOT find Python3 (missing: Python3_INCLUDE_DIRS Development.Module)
          (found suitable version "3.7.15", minimum required is "3.7")
        Call Stack (most recent call first):
          /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
          /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPython/Support.cmake:3203 (find_package_handle_standard_args)
          /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/cmake/data/share/cmake-3.24/Modules/FindPython3.cmake:490 (include)
          /vtk-wheel-sdk/vtk-9.2.2.data/headers/cmake/VTK-vtk-module-find-packages.cmake:444 (find_package)
          /vtk-wheel-sdk/vtk-9.2.2.data/headers/cmake/vtk-config.cmake:152 (include)
          CMakeLists.txt:29 (find_package)
        
        
        -- Configuring incomplete, errors occurred!
        See also "/project/_skbuild/linux-x86_64-3.7/cmake-build/CMakeFiles/CMakeOutput.log".
        See also "/project/_skbuild/linux-x86_64-3.7/cmake-build/CMakeFiles/CMakeError.log".
        /tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/setuptools_scm/git.py:135: UserWarning: "/project" is shallow and may cause errors
          warnings.warn(f'"{wd.path}" is shallow and may cause errors')
        Traceback (most recent call last):
          File "/tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/skbuild/setuptools_wrap.py", line 637, in setup
            languages=cmake_languages,
          File "/tmp/pip-build-env-w1ajn9iv/overlay/lib/python3.7/site-packages/skbuild/cmaker.py", line 334, in configure
            "An error occurred while configuring with CMake.\n"

Source: https://github.com/Kitware/LookingGlassVTKModule/actions/runs/3366862318/jobs/5594079792

@jcfr
Copy link
Member Author

jcfr commented Nov 1, 2022

Since I am working on enabling VTK wheel build for another project, I will investigate and report back.

@psavery
Copy link
Collaborator

psavery commented Nov 2, 2022

I re-ran the workflow on master and encountered the same error, so it must be due to some change that's happened recently in the CI build process (a dependency, a change to the docker image, etc.).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants