Fix opengl cmake for latest VTK #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of adding the definition manually, the recommended practice is to include `vtkRenderingOpenGLConfigure.h`. This is already used in `vtkLookingGlassInterface.cxx`
- This module is no longer available in VTK.
jspanchu
force-pushed
the
fix-opengl-cmake
branch
4 times, most recently
from
836942e
to
ef4c8be
Compare
jspanchu
force-pushed
the
fix-opengl-cmake
branch
from
ef4c8be
to
a6ce91d
Compare
|
@sankhesh, Actions are green! could you get someone with access to the device test out this PR? |
|
@psavery has a device to test with. |
|
I'll give it a quick try |
|
This worked for me, although I'll note that my device is no longer supported by Looking Glass, and I have to use an older version of their service that they don't support anymore either. However, since this PR is not intending to upgrade to their newer versions of the API, it looks good to me! Merge when ready. |
|
Thanks for testing @psavery! Can someone with write access please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the CMake and
vtk.modulefiles.VTK_USE_COCOAmacro. The previous approach is not the recommended way.VTK::opengl. The dependency onVTK::RenderingOpenGL2should've been sufficient.