-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: COMP: Include Halide v18.0.0 in build system #8
WIP: COMP: Include Halide v18.0.0 in build system #8
Conversation
710cabc
to
dfcbc3e
Compare
The issue was two-fold. The ITK filter should not link to The LLVM linking issues arise because the precompiled Halide static libary does not bundle LLVM, and by default To test that things link correctly I use the "my_first_generator" example from the tutorial, but I don't do anything with it apart from importing the header. |
I'm not quite sure why the CI runs are failing... It looks like for some reason the FetchContent logic is not triggered, so |
CI seems inconsistent; I tested locally with an equivalent |
Normally I would rebase-and-merge, but I'll squash to clean up the "WIP" commits. |
@allemangD
Closes #2
A few questions/notes regarding the implementation:
GetHalide.cmake
(or another name) file?zlib
is required, should we also build/include this in the build system? Or require the user to have this installed already?Halide::Generator
, which throws errors since it cannot find llvm, what are your thoughts here?So far I have tested this on Linux and Windows.