Pc 839 contactmoment search company 6 7 8 #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `Company_PostcodeHuisnummerSearchButton` method in `Locators.cs` for locating the search button by postcode and house number. - Added three new test methods in `SearchCompanyScenarios.cs`: * `SearchByVestigingsnummer_UniqueResultAsync` * `SearchByNonExistentKvknummerAsync` * `SearchByPostcodeAndHuisnummerAsync` - Changed `SearchPersonScenarios` class visibility from `internal` to `public` in `SearchPersonScenarios.cs`.
Added a new test method `SearchByNonExistentKvknummerAsync` to verify the behavior when searching for a company by a kvknummer not present in the database. Removed a redundant line that checked if the heading "Bedrijfsinformatie" contains the text "Bedrijfsinformatie".
Refactor `SearchCompanyScenarios.cs` to replace text check with visibility check for the heading "Bedrijfsinformatie". Add new test methods `SearchByNonExistentBedrijfsnaamAsync` and `SearchByKvknummer_MultipleRecordsAsync` to test searching by non-existent company name and KVK number with multiple records, respectively. Minor formatting adjustment in `SearchPersonScenarios.cs`.
felixcicatt
reviewed
Feb 11, 2025
Enhanced SearchCompanyScenarios.cs by adding `await Expect` statements to verify the visibility of company names after search actions. This ensures the correct company name is displayed on the information page. Minor formatting adjustments were also made for better code structure.
felixcicatt
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.