Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eerste opzet met Azure login 2FA base classes opzetten #844

Merged
merged 13 commits into from
Aug 5, 2024

Conversation

JustinICATT
Copy link
Contributor

dit is de eerste opzet voor playwright, inloggen in de azure AD met 2FA werkt nu en test initializers en base classes opgezet

Copy link
Contributor

@felixcicatt felixcicatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ziet er goed uit! Paar kleine opmerkingen. En misschien kan je een dummytest toevoegen, zodat er iets is dat we vanuit GitHub actions kunnen runnen om te zien of het inloggen werkt.

Kiss.Bff.EndToEndTest/BaseTestInitializer.cs Outdated Show resolved Hide resolved
Kiss.Bff.EndToEndTest/BaseTestInitializer.cs Outdated Show resolved Hide resolved
Kiss.Bff.EndToEndTest/BaseTestInitializer.cs Outdated Show resolved Hide resolved
Kiss.Bff.EndToEndTest/BaseTestInitializer.cs Outdated Show resolved Hide resolved
@KISSAdmin KISSAdmin requested a review from felixcicatt August 5, 2024 16:13
@felixcicatt felixcicatt merged commit e16768b into main Aug 5, 2024
6 checks passed
@felixcicatt felixcicatt deleted the #823-End-to-end-tests-met-playwright branch August 5, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants