Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[digital-carbon] Clean up cco2 handler logic #189

Open
wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

[digital-carbon] Clean up cco2 handler logic #189

wants to merge 3 commits into from

Conversation

psparacino
Copy link
Collaborator

Clean up logic in cco2 handler.

@psparacino psparacino changed the title ['digital-carbon`] Clean up cco2 handler logic [digital-carbon] Clean up cco2 handler logic Sep 9, 2024
0xAurelius
0xAurelius approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@0xAurelius 0xAurelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change itself seems fine but what's with this binary file? Should it maybe be in .gitignore to avoid conflicts?

@psparacino
Copy link
Collaborator Author

The code change itself seems fine but what's with this binary file? Should it maybe be in .gitignore to avoid conflicts?

Generated from the tests but yes, i'll gitignore them as they will recompile when they are in actions

@psparacino psparacino force-pushed the pdc/clean-up-cco2-handler branch from bb98a52 to c0c47fe Compare September 30, 2024 16:13
@psparacino psparacino changed the base branch from main to staging November 21, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xAurelius 0xAurelius 0xAurelius approved these changes

@must-be-carbon must-be-carbon Awaiting requested review from must-be-carbon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psparacino @0xAurelius