Add check for host process container before reading from hcshim (amaz…

…on-contributing#156)
KlwntSingh · Feb 1, 2024 · fc380a1 · fc380a1
1 parent 6cd1657
commit fc380a1
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/receiver/awscontainerinsightreceiver/internal/k8swindows/hcsshim/hcsshim.go b/receiver/awscontainerinsightreceiver/internal/k8swindows/hcsshim/hcsshim.go
@@ -63,13 +63,17 @@ func NewHnSProvider(logger *zap.Logger, info cExtractor.CPUMemInfoProvider, mext
 }
 
 func (hp *HCSStatsProvider) GetMetrics() ([]*cExtractor.CAdvisorMetric, error) {
-	containerToEndpointMap, err := hp.getContainerToEndpointMap()
-	if err != nil {
-		hp.logger.Error("failed to create container to endpoint map using HCS shim APIs, ", zap.Error(err))
-		return nil, err
+	var metrics []*cExtractor.CAdvisorMetric
+	if ci.IsWindowsHostProcessContainer() {
+		containerToEndpointMap, err := hp.getContainerToEndpointMap()
+		if err != nil {
+			hp.logger.Error("failed to create container to endpoint map using HCS shim APIs, ", zap.Error(err))
+			return nil, err
+		}
+		hp.containerToEndpoint = containerToEndpointMap
+		return hp.getPodMetrics()
 	}
-	hp.containerToEndpoint = containerToEndpointMap
-	return hp.getPodMetrics()
+	return metrics, nil
 }
 
 func (hp *HCSStatsProvider) getContainerMetrics(containerId string) (extractors.HCSStat, error) {