This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Add fix for theResponseShouldContainsHeaders #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @PedroTroller what about this one ? Really would like to see it merged and tagged ;) And BTW cheers to all the KNP Team! |
|
I don't think it's a good idea to modify this step definition. You should create a new step named This PR modifies the assertion from |
| @@ -198,7 +198,7 @@ public function iShouldReceiveResponse($httpCode, $shortType = null) | |||
| )); | |||
| } | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This space is a mistake, I think it's your IDE which added it 😉
|
@docteurklein sure but the default definition just do not work at all (since when can't tell)... so better to make it work even with a different assertion no? |
|
Error is: |
|
I would preferably fix the existing definition AND create another one for another assertion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented proposed solution by @victuxbb in #118. I would also like to add specs but since the entire
ApiContextis lacking specs and thetheResponseShouldContainsHeadersmethod doesn't work at all at the moment I propose to merge the solution provided by @victuxbb in #118 and worry about specs later.