This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Update nelmio/alice to ~3.0 #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, it’s probably a good idea to require php |
pimolo
suggested changes
Jul 20, 2018
composer.json
Outdated
| @@ -12,7 +12,7 @@ | |||
| "doctrine/data-fixtures": "~1.0", | |||
| "behat/mink-extension": "~2.0", | |||
| "fzaninotto/faker": "~1.4", | |||
| "nelmio/alice": "~2.0", | |||
| "nelmio/alice": "~3.0", | |||
There was a problem hiding this comment.
If you put ^3.1 instead, we could make this package compatible with Symfony4.
You also need to upgrade the php minimal version to ^7.0.
|
I have nothing against this change. It break the BC. Well, this project will hardly break the BC in next versions. So I guess there's nothing really wrong with that. Also it's still a Please notice anyway that the main branch for next version is |
Closed
tkulka
added a commit
to blossom-educational/FriendlyContexts
that referenced
this pull request
Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.