[1.0] Do not automatically create the base directory for Local adapter #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to KnpLabs#618 We throw an exception when building the adapter if the specified base directory does not exist. The write methods can still create sub directories (eg /base/my/very/deep/dir), however the /base directory have to be present. The developer should create this directory on its own before using the adapter.
akerouanton
approved these changes
Jul 1, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #618
We throw an exception when building the adapter if the specified base
directory does not exist. The write methods can still create sub
directories (eg /base/my/very/deep/dir), however the /base directory
have to be present.
The developer should create this directory on its own before using the
adapter.