feat: Secret Scanning + Code completion + User Migration #1111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actories, `PSR-18` clients and `HTTPlug` factories Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
…k all other arguments as deprecated Signed-off-by: Hari Darshan Gorana <[email protected]>
…tories` method and deprecate other arguments. Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
haridarshan
changed the title
Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
Signed-off-by: Hari Darshan Gorana <[email protected]>
|
Yo me, those should be a bunch of separate PRs instead of a PR with many unrelated things |
|
@haridarshan Sorry for the delay! But I agree with @stof to split this PR in separate feature PR's, to make it easier to reviewer and get them merged quicker. Can you do that please @haridarshan? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
PSR-17 factories,PSR-18 clientsandHTTPlug factories.Fixes:
repositoriesmethod of CurrentUser and User Api to pass additional parameters likeper_pageand makes the method future proof if GitHub decides to add more options and deprecate existing arguments in support of this new argument. (Ref: Why defaults don't match the github doc? #799 (comment))Docs:
repositoriesmethod in CurrentUser and User docCloses #1092, Closes #1080, Closes #1057, Closes #866, Closes #799, Closes #795