Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of secondary rate limit #1126

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

mathieudz
Copy link
Contributor

Actual error message is "You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID [...]"

Actual error message is "You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID [...]"
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @mathieudz, can you also update the unit test to reflect the real world api response? Thanks!

'message' => 'You have exceeded a secondary rate limit. Please wait a few minutes before you try again.',

@acrobat acrobat merged commit 9d19af3 into KnpLabs:master Nov 19, 2023
9 of 10 checks passed
@acrobat
Copy link
Collaborator

acrobat commented Nov 19, 2023

Thanks @mathieudz! And congrats on your first contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants