Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add per_page and page parameters to Member->all() #1140

Closed

Conversation

nickpoulos
Copy link
Contributor

This allows developers to actually get all() members.

This allows developers to actually get all() members.
Copy link
Contributor

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. The result pager is for this. https://github.com/KnpLabs/php-github-api/blob/master/doc/result_pager.md

@nickpoulos
Copy link
Contributor Author

Ah thank you, my mistake. I missed this in the docs. Will close PR.

@nickpoulos nickpoulos closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants