Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NetMHCpan: False peptide min/max boundaries #91

Open
jonasscheid opened this issue Jul 24, 2023 · 5 comments
Open

NetMHCpan: False peptide min/max boundaries #91

jonasscheid opened this issue Jul 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@jonasscheid
Copy link
Collaborator

The internal boundaries of netmhcpan regarding peptide lengths are 8 - 56. NetMHCpan 4.1 always picks the most relevant Core of the peptide and does prediction on it. That is currently prohibited by the supported length that is inherited by the netmhcpan 2.8 interface.

Regarding NetMHCIIpan there seems to be only a lower limit to 9mers, I can go beyond 100 amino acids, which clearly does not make sense. So we could also say that we restrict it to peptides having max length of 56

@jonasscheid jonasscheid added the bug Something isn't working label Jul 24, 2023
@christopher-mohr
Copy link
Collaborator

Thanks for adding the issue.

I'm not sure yet if I understand it completely. Could you provide an example how that results in different or wrong results? How does that affect the predictions when we provide peptides directly anyway?

I guess in general it makes sense though to adjust the allowed peptide lengths to the tools' values.

@jonasscheid
Copy link
Collaborator Author

I does not lead to wrong results, but class 1 peptides > 14 cannot be predicted by netmhcpan. Also netmhcIIpan is capped to peptides <20, which is a problem if we want to predict 21, 22mers. I think we don't need to change anything in parsing, it's just the boundaries of the peptide lengths.

What I wanted to say is that netmhc gets the most interesting core of the peptide and does the prediction on that:
Screenshot 2023-07-24 at 17 41 02

@christopher-mohr
Copy link
Collaborator

I am still not sure I understand how the core is related to the problem with not having allowed all possible peptide lengths. The core is always the 9mer that is predicted to be in contact with the HLA molecule. I think the prediction is still done on the whole peptide though but would have to look up the details.

@jonasscheid
Copy link
Collaborator Author

jonasscheid commented Jul 25, 2023

You are right, sorry for the confusion. I checked prediction with the core peptide and the rank is different. So let's allow all possible peptide lengths then?

@christopher-mohr
Copy link
Collaborator

Sounds good to me, still worth to be changed. Thanks for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants