Skip to content

Commit

Permalink
feat(kgo): drop kube-rbac-proxy, expose metrics by default (#1243)
Browse files Browse the repository at this point in the history
  • Loading branch information
pmalek authored Feb 3, 2025
1 parent 1903dd5 commit bdb2fb4
Show file tree
Hide file tree
Showing 15 changed files with 901 additions and 25 deletions.
12 changes: 12 additions & 0 deletions charts/gateway-operator/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
# Changelog

## 0.4.8

## Changes

- Remove kube-rbac-proxy for operator versions 1.5+.
In order to controler metrics endpoint access for these version please see
[kubernetes-sigs/kubebuilder/discussions/3907][kubebuilder_discussion_3907].
Operator exposes `--metrics-access-filter` flag to control access to the metrics endpoint.
[#1243](https://github.com/Kong/charts/pull/1243)

[kubebuilder_discussion_3907]: https://github.com/kubernetes-sigs/kubebuilder/discussions/3907

## 0.4.7

## Changes
Expand Down
2 changes: 1 addition & 1 deletion charts/gateway-operator/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ maintainers:
name: gateway-operator
sources:
- https://github.com/Kong/charts/tree/main/charts/gateway-operator
version: 0.4.7
version: 0.4.8
appVersion: "1.4"
annotations:
artifacthub.io/prerelease: "false"
Expand Down
9 changes: 6 additions & 3 deletions charts/gateway-operator/ci/__snapshots__/affinity-values.snap
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ kind: Deployment
metadata:
labels:
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -718,7 +718,7 @@ spec:
labels:
control-plane: controller-manager
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -743,7 +743,7 @@ spec:
- name: GATEWAY_OPERATOR_HEALTH_PROBE_BIND_ADDRESS
value: ":8081"
- name: GATEWAY_OPERATOR_METRICS_BIND_ADDRESS
value: "127.0.0.1:8080"
value: "0.0.0.0:8080"
- name: POD_NAMESPACE
valueFrom:
fieldRef:
Expand Down Expand Up @@ -781,6 +781,9 @@ spec:
- containerPort: 8081
name: probe
protocol: TCP
- containerPort: 8080
name: metrics
protocol: TCP
volumeMounts:
- name: chartsnap-gateway-operator-certs-dir
mountPath: /tmp/k8s-webhook-server/serving-certs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ kind: Deployment
metadata:
labels:
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -718,7 +718,7 @@ spec:
labels:
control-plane: controller-manager
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -735,7 +735,7 @@ spec:
- name: GATEWAY_OPERATOR_HEALTH_PROBE_BIND_ADDRESS
value: ":8081"
- name: GATEWAY_OPERATOR_METRICS_BIND_ADDRESS
value: "127.0.0.1:8080"
value: "0.0.0.0:8080"
- name: POD_NAMESPACE
valueFrom:
fieldRef:
Expand Down Expand Up @@ -773,6 +773,9 @@ spec:
- containerPort: 8081
name: probe
protocol: TCP
- containerPort: 8080
name: metrics
protocol: TCP
volumeMounts:
- name: chartsnap-gateway-operator-certs-dir
mountPath: /tmp/k8s-webhook-server/serving-certs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ kind: Deployment
metadata:
labels:
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -718,7 +718,7 @@ spec:
labels:
control-plane: controller-manager
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -735,7 +735,7 @@ spec:
- name: GATEWAY_OPERATOR_HEALTH_PROBE_BIND_ADDRESS
value: ":8081"
- name: GATEWAY_OPERATOR_METRICS_BIND_ADDRESS
value: "127.0.0.1:8080"
value: "0.0.0.0:8080"
- name: POD_NAMESPACE
valueFrom:
fieldRef:
Expand Down Expand Up @@ -773,6 +773,9 @@ spec:
- containerPort: 8081
name: probe
protocol: TCP
- containerPort: 8080
name: metrics
protocol: TCP
volumeMounts:
- name: chartsnap-gateway-operator-certs-dir
mountPath: /tmp/k8s-webhook-server/serving-certs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ kind: Deployment
metadata:
labels:
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -718,7 +718,7 @@ spec:
labels:
control-plane: controller-manager
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
app.kubernetes.io/component: kgo
Expand All @@ -737,7 +737,7 @@ spec:
- name: GATEWAY_OPERATOR_HEALTH_PROBE_BIND_ADDRESS
value: ":8081"
- name: GATEWAY_OPERATOR_METRICS_BIND_ADDRESS
value: "127.0.0.1:8080"
value: "0.0.0.0:8080"
- name: POD_NAMESPACE
valueFrom:
fieldRef:
Expand Down Expand Up @@ -775,6 +775,9 @@ spec:
- containerPort: 8081
name: probe
protocol: TCP
- containerPort: 8080
name: metrics
protocol: TCP
volumeMounts:
- name: chartsnap-gateway-operator-certs-dir
mountPath: /tmp/k8s-webhook-server/serving-certs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -696,7 +696,7 @@ kind: Deployment
metadata:
labels:
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
a: "b"
Expand All @@ -719,7 +719,7 @@ spec:
labels:
control-plane: controller-manager
app.kubernetes.io/name: gateway-operator
helm.sh/chart: gateway-operator-0.4.7
helm.sh/chart: gateway-operator-0.4.8
app.kubernetes.io/instance: "chartsnap"
app.kubernetes.io/version: "1.4"
a: "b"
Expand All @@ -735,7 +735,7 @@ spec:
- name: GATEWAY_OPERATOR_HEALTH_PROBE_BIND_ADDRESS
value: ":8081"
- name: GATEWAY_OPERATOR_METRICS_BIND_ADDRESS
value: "127.0.0.1:8080"
value: "0.0.0.0:8080"
- name: POD_NAMESPACE
valueFrom:
fieldRef:
Expand Down Expand Up @@ -773,6 +773,9 @@ spec:
- containerPort: 8081
name: probe
protocol: TCP
- containerPort: 8080
name: metrics
protocol: TCP
volumeMounts:
- name: chartsnap-gateway-operator-certs-dir
mountPath: /tmp/k8s-webhook-server/serving-certs
Expand Down
Loading

0 comments on commit bdb2fb4

Please sign in to comment.