Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): bump github.com/daveshanley/vacuum from 0.9.15 to 0.16.3" #1534

Conversation

Prashansa-K
Copy link
Contributor

Reverts #1528

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.15%. Comparing base (ab748dc) to head (29fcdfb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1534      +/-   ##
==========================================
+ Coverage   29.09%   29.15%   +0.05%     
==========================================
  Files          62       62              
  Lines        6682     6682              
==========================================
+ Hits         1944     1948       +4     
+ Misses       4599     4596       -3     
+ Partials      139      138       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mheap
Copy link
Member

mheap commented Feb 13, 2025

@Prashansa-K Please talk to @czeslavo as this is a required change for KIC

@czeslavo
Copy link
Contributor

It looks like daveshanley/vacuum still has a bug causing another race condition than the one for which I contributed a fix. It happens locally every 3rd/4th test run. In this case we can revert it. I'll look into the upstream code to see if it's easy to fix. If not, I will report a bug. For KIC, if we bump deck to a proper version in GDR, it will be enough.

@czeslavo czeslavo merged commit bd7b01d into main Feb 14, 2025
23 checks passed
@czeslavo czeslavo deleted the revert-1528-dependabot/go_modules/github.com/daveshanley/vacuum-0.16.3 branch February 14, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants