-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Ubuntu 24.04 to build matrix #13626
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/docs
chore
Not part of the core functionality of kong, but still needed
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
labels
Sep 5, 2024
2 tasks
curiositycasualty
force-pushed
the
feat/ubuntu-noble-numbat
branch
from
September 5, 2024 21:24
362cabc
to
d6dc14c
Compare
A separate PR addressing |
2 tasks
curiositycasualty
force-pushed
the
feat/ubuntu-noble-numbat
branch
from
September 5, 2024 21:40
d6dc14c
to
49b5204
Compare
fffonion
reviewed
Sep 6, 2024
fffonion
reviewed
Sep 6, 2024
fffonion
reviewed
Sep 6, 2024
fffonion
reviewed
Sep 6, 2024
curiositycasualty
force-pushed
the
feat/ubuntu-noble-numbat
branch
from
September 6, 2024 16:37
49b5204
to
3df200a
Compare
Co-authored-by: Wangchong Zhou <[email protected]>
curiositycasualty
force-pushed
the
feat/ubuntu-noble-numbat
branch
from
September 6, 2024 21:58
2c1de64
to
fa65f8d
Compare
fffonion
approved these changes
Sep 9, 2024
Water-Melon
approved these changes
Sep 9, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13626-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13626-to-master-to-upstream
git checkout -b cherry-pick-13626-to-master-to-upstream
ancref=$(git merge-base ad3e19a61580b1c1c8e84dce34b8a198b82c89cf fa65f8dc7fe420161f5fcac3093bea70fa9ccec3)
git cherry-pick -x $ancref..fa65f8dc7fe420161f5fcac3093bea70fa9ccec3 |
github-actions
bot
added
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 9, 2024
kikito
removed
the
incomplete-cherry-pick
A cherry-pick was incomplete and needs manual intervention
label
Sep 10, 2024
curiositycasualty
added a commit
that referenced
this pull request
Oct 15, 2024
* feat: add ubuntu 24.04 to build matrix * fix(bazel): libxcrypt 2404 version comment Co-authored-by: Wangchong Zhou <[email protected]> * fix(gha): rm unneeded python on runner --------- Co-authored-by: Wangchong Zhou <[email protected]> (cherry picked from commit f9e6f39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build/bazel
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
core/docs
size/XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the next LTS version of Ubuntu, and makes it the default Ubuntu version used for building PRs, the
-ubuntu
tagged docker images, etc. Notably, this PR does NOT change anyruns-on
statements for github actions. A later PR will need to address that.Had to make some changes to get the build rolling on 24.04:
libxcrypt
patch that fixes some logic in their build scripts that wasn't adapted for modern perlGID
andUID
in the docker parts of the explain_manifest script (ubuntu
is already UID 1000 in Noble Numbat)libsimdjson_ffi.so
andlibada.so
to the new explain_manifest fixturescheck-manifest-suite
for docker suchkong_uid
andkong_gid
can be passedChecklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #KAG-4672
Replaces: #13121