Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Ubuntu 24.04 to build matrix #13626

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

curiositycasualty
Copy link
Contributor

@curiositycasualty curiositycasualty commented Sep 5, 2024

Summary

This PR introduces the next LTS version of Ubuntu, and makes it the default Ubuntu version used for building PRs, the -ubuntu tagged docker images, etc. Notably, this PR does NOT change any runs-on statements for github actions. A later PR will need to address that.

Had to make some changes to get the build rolling on 24.04:

  • a libxcrypt patch that fixes some logic in their build scripts that wasn't adapted for modern perl
  • parameterize the GID and UID in the docker parts of the explain_manifest script (ubuntu is already UID 1000 in Noble Numbat)
  • add libsimdjson_ffi.so and libada.so to the new explain_manifest fixtures
  • add a new check-manifest-suite for docker such kong_uid and kong_gid can be passed

Checklist

Issue reference

Fix #KAG-4672

Replaces: #13121

@github-actions github-actions bot added core/docs chore Not part of the core functionality of kong, but still needed build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Sep 5, 2024
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Sep 5, 2024
@curiositycasualty
Copy link
Contributor Author

A separate PR addressing runs-on will have to come later.

@curiositycasualty curiositycasualty marked this pull request as ready for review September 5, 2024 21:34
@curiositycasualty curiositycasualty marked this pull request as draft September 5, 2024 21:35
@curiositycasualty curiositycasualty marked this pull request as ready for review September 5, 2024 21:40
@curiositycasualty curiositycasualty merged commit f9e6f39 into master Sep 9, 2024
27 checks passed
@curiositycasualty curiositycasualty deleted the feat/ubuntu-noble-numbat branch September 9, 2024 17:28
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13626-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13626-to-master-to-upstream
git checkout -b cherry-pick-13626-to-master-to-upstream
ancref=$(git merge-base ad3e19a61580b1c1c8e84dce34b8a198b82c89cf fa65f8dc7fe420161f5fcac3093bea70fa9ccec3)
git cherry-pick -x $ancref..fa65f8dc7fe420161f5fcac3093bea70fa9ccec3

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 9, 2024
@kikito kikito removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 10, 2024
curiositycasualty added a commit that referenced this pull request Oct 15, 2024
* feat: add ubuntu 24.04 to build matrix

* fix(bazel): libxcrypt 2404 version comment

Co-authored-by: Wangchong Zhou <[email protected]>

* fix(gha): rm unneeded python on runner

---------

Co-authored-by: Wangchong Zhou <[email protected]>
(cherry picked from commit f9e6f39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed core/docs size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants