fix(clustering): report node version in sync #13844
Open
+49
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
cherry-pick kong-ee
chronolaw
changed the title
chronolaw
force-pushed
the
feat/add_kong_version_for_sync
branch
2 times, most recently
from
9546acb
to
af1f6b8
Compare
dndx
requested changes
Nov 14, 2024
chronolaw
force-pushed
the
feat/add_kong_version_for_sync
branch
from
d11e6f5
to
0a9f335
Compare
|
@dndx I have changed the implementation, could you take a look again? thanks. |
+1. Please consider redesign the solution |
StarlightIbuki
requested changes
Nov 18, 2024
StarlightIbuki
approved these changes
Nov 18, 2024
chobits
reviewed
Nov 18, 2024
chobits
approved these changes
Nov 18, 2024
|
This seems to be going to be covered by a new change. Are we going to close this? |
chronolaw
force-pushed
the
feat/add_kong_version_for_sync
branch
from
8630f2c
to
edc253a
Compare
This PR is re-implemented to work with meta rpc call. |
|
@dndx , could you take a look and approve it? thanks. |
chobits
approved these changes
Nov 25, 2024
chobits
approved these changes
Nov 25, 2024
dndx
requested changes
Nov 25, 2024
Comment on lines
+206
to
+209
| self.client_info[node_id] = { | ||
| ip = ngx_var.remote_addr, | ||
| version = info.kong_version, | ||
| } |
There was a problem hiding this comment.
Should _handle_meta_call also assert(self.concentrator)? In case self.client_info is not set.
chobits
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
May change after KAG-5369 and #13887
KAG-5772
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]