Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clustering/rpc): inert rpc protocol by default in 3.9 #13925

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

chronolaw
Copy link
Contributor

Summary

KAG-5908

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added core/configuration cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 26, 2024
@chronolaw chronolaw added this to the 3.9.0 milestone Nov 26, 2024
@@ -94,6 +94,7 @@ for _, strategy in helpers.each_strategy() do
cluster_cert_key = "spec/fixtures/kong_clustering.key",
cluster_listen = "127.0.0.1:9005",
nginx_conf = "spec/fixtures/custom_nginx.template",
cluster_rpc = "on",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we set it to inc_sync?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about it, but I think that cp should always support two prorocols.

Copy link
Contributor

@chobits chobits Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know andy's meaning, but it need some effort to enable it, he want us to test the following 3 kinds of scenarios:

  1. rpc = off, inc_sync = off <-- and this one is our default action, this is not tested in these test cases
  2. rpc = on, inc_sync = off
  3. rpc = on, inc_sync = on

the double for-loop might be tricky:

for rpc in {off, on}
   for inc_sync in {off, on}
      if rpc == off, inc_sync == on then
          continue
      end
      ... run test ...

or

--- gpt generated code
for _, pair in ipairs({{"off", "off"}, {"on", "off"}, {"on", "on"}}) do
   print("rpc: " .. pair[1] .. ", inc_sync: " .. pair[2]) end

 ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thank you.

@chronolaw chronolaw marked this pull request as ready for review November 26, 2024 10:32
@chronolaw chronolaw changed the title fix(clustering/rpc): inert rpc protocol in 3.9 fix(clustering/rpc): inert rpc protocol by default in 3.9 Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants