-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clustering/rpc): inert rpc protocol by default in 3.9 #13925
base: master
Are you sure you want to change the base?
Conversation
@@ -94,6 +94,7 @@ for _, strategy in helpers.each_strategy() do | |||
cluster_cert_key = "spec/fixtures/kong_clustering.key", | |||
cluster_listen = "127.0.0.1:9005", | |||
nginx_conf = "spec/fixtures/custom_nginx.template", | |||
cluster_rpc = "on", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we set it to inc_sync?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about it, but I think that cp should always support two prorocols.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know andy's meaning, but it need some effort to enable it, he want us to test the following 3 kinds of scenarios:
- rpc = off, inc_sync = off <-- and this one is our default action, this is not tested in these test cases
- rpc = on, inc_sync = off
- rpc = on, inc_sync = on
the double for-loop might be tricky:
for rpc in {off, on}
for inc_sync in {off, on}
if rpc == off, inc_sync == on then
continue
end
... run test ...
or
--- gpt generated code
for _, pair in ipairs({{"off", "off"}, {"on", "off"}, {"on", "on"}}) do
print("rpc: " .. pair[1] .. ", inc_sync: " .. pair[2]) end
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done, thank you.
This reverts commit 572a079.
Summary
KAG-5908
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]