tests(clustering/rpc): enable 09-hybrid_mode/01-sync_spec.lua for incremental sync #13959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cherry-pick kong-ee
chobits
commented
Dec 2, 2024
Comment on lines
+796
to
+801
| -- TODO: The API output does include labels and certs when the | ||
| -- incremental sync is enabled. | ||
| if inc_sync == "off" then | ||
| assert.equal("mycloud", v.labels.deployment) | ||
| assert.equal("us-east-1", v.labels.region) | ||
| end |
There was a problem hiding this comment.
For perfect solution, we need to add a feature for incremental sync: https://konghq.atlassian.net/browse/KAG-5935
chronolaw
approved these changes
Dec 2, 2024
chronolaw
changed the title
chronolaw
changed the title
StarlightIbuki
approved these changes
Dec 2, 2024
|
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13959-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13959-to-master-to-upstream
git checkout -b cherry-pick-13959-to-master-to-upstream
ancref=$(git merge-base 35aa60546de8d313c792f32afcb3ec71fd179520 8c8da0e653655f9a70bc1f854d92e4a547cad3aa)
git cherry-pick -x $ancref..8c8da0e653655f9a70bc1f854d92e4a547cad3aamanual cherry-pick: https://github.com/Kong/kong-ee/pull/10922 |
github-actions
bot
added
the
incomplete-cherry-pick
kikito
removed
the
incomplete-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable all tests of 09-hybrid_mode/01-sync_spec.lua under incremental sync on mode
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
Fix KAG-5951