fix(prometheus): add a toggle switch for wasm metrics export #13960
+57
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/clustering
plugins/prometheus
schema-change-noteworthy
cherry-pick kong-ee
|
@fffonion can you let me know if this is what you were looking for? It is not possible to control export on a per service/route basis for Wasm. It's a little weird putting a global toggle into a configuration field that is not global, but from what I can tell we're doing something similar with |
|
@flrgh yes, I think a plugin side of config like this is fine 👍. prometheus is still a plugin not a first class component in kong so putting into kong.conf is indeed weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a toggle for wasm metrics export to the prometheus plugin.
Issue reference
KAG-5904