Multiplatform benchmarks baseline #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
changed the title
qwwdfsad
changed the title
|
I see that the |
| "--add-exports", "java.base/sun.security.action=ALL-UNNAMED", | ||
| "--add-exports", "java.base/jdk.internal.util=ALL-UNNAMED") // in the model checking mode | ||
| "--add-exports", "java.base/jdk.internal.util=ALL-UNNAMED" | ||
| ) // in the model checking mode |
There was a problem hiding this comment.
Pro tip: use Difftastic when reviewing such changes! In a structural diff, the trivial formatting edits don't show up at all.
dkhalanskyjb
approved these changes
Feb 13, 2025
| ./gradlew :kotlinx-coroutines-core:macosArm64BenchmarkBenchmark | ||
|
|
||
| // Figure out what to use | ||
| ./gradlew :kotlinx-coroutines-core:tasks | grep -i bench |
There was a problem hiding this comment.
Suggested change
| ./gradlew :kotlinx-coroutines-core:tasks | grep -i bench | |
| ./gradlew :kotlinx-coroutines-core:tasks | grep -i "BenchmarkBenchmark " |
Seems much more reliable.
There was a problem hiding this comment.
I explicitly opted into mine version -- shorter, more robust (also, will showcase non-launcing tasks, for example macosArm64BenchmarkBinaries to copy around)
fzhinkin
approved these changes
Feb 18, 2025
| @@ -4,6 +4,7 @@ group=org.jetbrains.kotlinx | |||
| kotlin_version=2.1.0 | |||
| # DO NOT rename this property without adapting kotlinx.train build chain: | |||
| atomicfu_version=0.26.1 | |||
| benchmarks_version=0.4.13 | |||
There was a problem hiding this comment.
It might be worth plugging benchmarks_jmh_version=1.37 here, otherwise benchmarks will use pretty ancient version of JMH (1.21).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this for Kotlin/kotlinx-atomicfu#499 and decided to tidy it up a bit and make it usable.
Adding @fzhinkin to verify the sourcesets setup