Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHT example with CoSim #138

Merged
merged 1 commit into from
Sep 5, 2024
Merged

CHT example with CoSim #138

merged 1 commit into from
Sep 5, 2024

Conversation

Igarizza
Copy link
Member

@Igarizza Igarizza commented Aug 9, 2024

PR adds an example of cylinder cooling with CoSimApp.

@Igarizza Igarizza requested a review from matekelemen August 9, 2024 09:12
Copy link
Contributor

@matekelemen matekelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@rubenzorrilla
Copy link
Member

This is the very same example as the one in the CHT folder. Rather than copying and pasting the README.md, I'd suggest to refer to it and explain that the one in here is the very same but with a CoSimulation-based set up.


## Case Specification

#### The test case is implemented based on the [CHT example](https://github.com/KratosMultiphysics/Examples/tree/master/conjugate_heat_transfer/validation/cylinder_cooling_Re100_Pr2) using CoSimulationApplication.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rubenzorrilla it is the same example, and it is referenced to the original source. I keep the original description to help potential reader faster understand the example.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Fair enough. No objections from my side.

@Igarizza Igarizza merged commit 314ee6b into master Sep 5, 2024
1 check passed
@rubenzorrilla rubenzorrilla deleted the adding_CHT_CoSim_Example branch September 6, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants