fixes to avoid WError

KratosMultiphysics · May 16, 2024 · 06b93a9 · 06b93a9
1 parent 7f2d444
commit 06b93a9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 16 deletions.
diff --git a/applications/GeoMechanicsApplication/custom_constitutive/thermal_dispersion_law.cpp b/applications/GeoMechanicsApplication/custom_constitutive/thermal_dispersion_law.cpp
@@ -13,16 +13,17 @@
 //
 
 #include "custom_constitutive/thermal_dispersion_law.h"
+#include "custom_retention/retention_law_factory.h"
 #include "geo_mechanics_application_variables.h"
 
 namespace Kratos
 {
 
-GeoThermalDispersionLaw::GeoThermalDispersionLaw() : GeoThermalLaw() {}
+GeoThermalDispersionLaw::GeoThermalDispersionLaw() { mNumberOfDimensions = 2; }
 
 GeoThermalDispersionLaw::GeoThermalDispersionLaw(std::size_t NumberOfDimensions)
-    : GeoThermalLaw(NumberOfDimensions)
 {
+    mNumberOfDimensions = NumberOfDimensions;
     KRATOS_ERROR_IF(mNumberOfDimensions < 1 || mNumberOfDimensions > 3)
         << "Got invalid number of dimensions: " << mNumberOfDimensions << std::endl;
 }

diff --git a/applications/GeoMechanicsApplication/custom_constitutive/thermal_filter_law.cpp b/applications/GeoMechanicsApplication/custom_constitutive/thermal_filter_law.cpp
@@ -17,11 +17,11 @@
 namespace Kratos
 {
 
-GeoThermalFilterLaw::GeoThermalFilterLaw() : GeoThermalLaw() {}
+GeoThermalFilterLaw::GeoThermalFilterLaw() { mNumberOfDimensions = 1; }
 
 GeoThermalFilterLaw::GeoThermalFilterLaw(SizeType NumberOfDimensions)
-    : GeoThermalLaw(NumberOfDimensions)
 {
+    mNumberOfDimensions = NumberOfDimensions;
     KRATOS_ERROR_IF(mNumberOfDimensions != 1)
         << "Got invalid number of dimensions. The dimension has to be 1, but got: " << mNumberOfDimensions
         << std::endl;

diff --git a/applications/GeoMechanicsApplication/custom_constitutive/thermal_law.h b/applications/GeoMechanicsApplication/custom_constitutive/thermal_law.h
@@ -14,7 +14,6 @@
 
 #pragma once
 
-#include "custom_retention/retention_law_factory.h"
 #include "geo_mechanics_application_variables.h"
 #include "includes/serializer.h"
 
@@ -32,22 +31,14 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) GeoThermalLaw
     /// Counted pointer of GeoThermalLaw
     KRATOS_CLASS_POINTER_DEFINITION(GeoThermalLaw);
 
-    GeoThermalLaw() : mNumberOfDimensions{2} {};
-
-    explicit GeoThermalLaw(std::size_t NumberOfDimensions) : mNumberOfDimensions{NumberOfDimensions}
-    {
-        KRATOS_ERROR_IF(mNumberOfDimensions < 1 || mNumberOfDimensions > 3)
-            << "Got invalid number of dimensions: " << mNumberOfDimensions << std::endl;
-    }
+    GeoThermalLaw() {}
 
     virtual GeoThermalLaw::Pointer Clone() const = 0;
 
     std::size_t WorkingSpaceDimension() const { return mNumberOfDimensions; }
 
-    virtual Matrix CalculateThermalDispersionMatrix(const Properties& rProp, const ProcessInfo& rProcessInfo) const
-    {
-        return ZeroMatrix(1, 1);
-    }
+    virtual Matrix CalculateThermalDispersionMatrix(const Properties&  rProp,
+                                                    const ProcessInfo& rProcessInfo) const = 0;
 
 protected:
     std::size_t mNumberOfDimensions = 0;