Kratos Rotating Frame Process #11158

SADPR · 2023-05-19T10:14:30Z

Overview

This Pull Request introduces a new process in the FluidDynamicsApplication, called the RotatingFrameProcess. This process applies a rotation transformation and imparts a constant or accelerated angular velocity to a given model part in a rotating frame of reference. This process leverages the functions provided by the new utility RotatingFrameUtility to carry out these tasks.

Changes Made

applications/FluidDynamicsApplication/CMakeLists.txt: The rotating_frame_utility.cpp file has been added to the list of source files to be compiled.
applications/FluidDynamicsApplication/custom_python/add_custom_utilities_to_python.cpp: The RotatingFrameUtility is now exposed to Python.
applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp and rotating_frame_utility.h: These files contain the C++ implementation of the RotatingFrameUtility. This utility facilitates the application of a rotation and mesh displacement to a given model part and imparts an angular velocity to it, which can be either constant or time-varying.
applications/FluidDynamicsApplication/python_scripts/rotating_frame_process.py: This Python process utilizes the RotatingFrameUtility. It calls the utility's functions in the appropriate sequence to implement the rotating frame transformation and the associated velocity application.
applications/FluidDynamicsApplication/tests/test_rotating_frame_process.py: This Python test validates the functionality of both the RotatingFrameUtility and the associated Python process.
applications/FluidDynamicsApplication/tests/RotatingFrameProcessTest/RotatingFrameProcessTest.mdpa and RotatingFrameProcessTestResults.json: These files contain the model part and the expected test results for the Python test respectively.

Please review and let me know if any changes are required.
Here is a visual representation:

loumalouomega · 2023-05-19T10:26:24Z

Why Fluid app?, is quite generic, isn`t?

loumalouomega · 2023-05-19T10:27:23Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

@@ -0,0 +1,120 @@
+//    |  /           |


Fluid app has a different header?

No, I don't see any other utility with a different header.

loumalouomega · 2023-05-19T10:31:30Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+        velocity_vector = MathUtils<double>::CrossProduct(angular_velocity_vector, position_vector);
+
+        // Setting the node's velocity
+        rNode.FastGetSolutionStepValue(VELOCITY_X) = velocity_vector[0];


I think is more efficient if you assign values using the whole vector (or potentially can be if using SIMD), also is shorter and simpler

loumalouomega · 2023-05-19T10:32:16Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+
+        // Shifting the point back and updating the node coordinates
+        rotated_point += rCenterOfRotation;
+        rNode.FastGetSolutionStepValue(MESH_DISPLACEMENT_X) = rotated_point[0] - rNode.X0();


Idem, assign vector is better

loumalouomega · 2023-05-19T10:32:26Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+        rNode.Fix(MESH_DISPLACEMENT_X);
+        rNode.Fix(MESH_DISPLACEMENT_Y);
+        rNode.Fix(MESH_DISPLACEMENT_Z);
+        rNode.X() = rotated_point[0];


Idem, vector assign

loumalouomega · 2023-05-19T10:32:52Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.h

+#if !defined(KRATOS_ROTATING_FRAME_UTILITY_H)
+#define KRATOS_ROTATING_FRAME_UTILITY_H


#pragma once

loumalouomega

Some comments

rubenzorrilla · 2023-06-06T19:30:40Z

Why Fluid app?, is quite generic, isn`t?

Agree. I think that the best place for this is the MeshMovingApplication. Alternatively, we could directly implement it in the core.

rubenzorrilla · 2023-06-06T19:33:10Z

applications/FluidDynamicsApplication/python_scripts/rotating_frame_process.py

+            "rotating_frame_model_part_name": "",
+            "rotating_object_model_part_name": "",


Which is the difference between these two? Aren't you doing the rotation in the entire model part?

The rotating_frame_model_part_name refers to the computational domain treated as being in a rotational state, typically employed in the sliding mesh approach to capture the effects of the rotating zone. On the other hand, the rotating_object_model_part_name denotes the specific entity or component, like a turbine blade or a rotor, that necessitates the assignment of the rotational velocity. Essentially, while the rotating frame captures the overall moving region in the computational sense, the rotating object represents the actual physical component causing this rotation.

SADPR · 2023-08-22T09:37:20Z

Given the utility's primary role in assigning velocities, I feel it's more intuitive to place it within the FluidDynamicsApplication. Both velocity and mesh displacements are intrinsic variables in fluid dynamics' arbitrary lagrangian eulerian (ALE) formulation, especially for its application in sliding mesh scenarios. Incorporating it here ensures that developers and users have direct access in the most pertinent contexts. It just seems like a natural and strategic alignment with our current and prospective projects (*TO ME). Do you think it truly has a better home in the mesh moving? @loumalouomega @rubenzorrilla

SADPR · 2023-08-22T09:39:23Z

I've implemented all the suggestions. The only point left for discussion is whether to move it to the MeshMoving or to retain it here in the FluidDynamicsApplication.

SADPR · 2023-09-10T10:59:48Z

@loumalouomega could you please take a quick view to this? I did all suggestions and the only discussion left is whether to move it to the MeshMoving or to retain it here in the FluidDynamicsApplication. Thanks!

SADPR · 2023-10-19T16:16:57Z

@loumalouomega and @rubenzorrilla I would like to close this PR. Can you help me? 😄

loumalouomega · 2023-10-19T16:35:07Z

@loumalouomega and @rubenzorrilla I would like to close this PR. Can you help me? 😄

Merge or close?, because close is easy...

loumalouomega

Remove block

loumalouomega · 2023-10-19T16:37:34Z

Now it depends on @rubenzorrilla

SADPR · 2023-10-19T18:08:48Z

@loumalouomega and @rubenzorrilla I would like to close this PR. Can you help me? 😄

Merge or close?, because close is easy...

😆 merge! Okay, I'll wait for Ruben's response.

rubenzorrilla · 2023-10-30T14:16:12Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.h

+// System includes
+#include <string>
+#include <iostream>
+
+// External includes
+#include "includes/mesh_moving_variables.h"
+
+// Include kratos definitions
+#include "includes/define.h"
+
+// Application includes
+#include "utilities/variable_utils.h"
+
+// Project includes
+#include "utilities/builtin_timer.h"
+#include "utilities/math_utils.h"


Suggested change

// System includes

#include <string>

#include <iostream>

// External includes

#include "includes/mesh_moving_variables.h"

// Include kratos definitions

#include "includes/define.h"

// Application includes

#include "utilities/variable_utils.h"

// Project includes

#include "utilities/builtin_timer.h"

#include "utilities/math_utils.h"

// System includes

#include <string>

#include <iostream>

// External includes

// Project includes

#include "includes/define.h"

#include "includes/mesh_moving_variables.h"

#include "utilities/builtin_timer.h"

#include "utilities/math_utils.h"

#include "utilities/variable_utils.h"

// Application includes

To follow our standard include lists.

rubenzorrilla · 2023-10-30T14:27:05Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+// External includes
+
+// Application includes


Suggested change

// External includes

// Application includes

// External includes

// Project includes

// Application includes

rubenzorrilla · 2023-10-30T16:00:01Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+        array_1d<double, 3> position_vector = r_point - rCenterOfRotation;
+
+        // Computing the velocity due to rotation (v = omega cross r)
+        array_1d<double, 3> velocity_vector = MathUtils<double>::CrossProduct(angular_velocity_vector, position_vector);


I'd pass velocity_vector as a TLS (so you avoid allocating and deallocating each time).

rubenzorrilla · 2023-10-30T16:00:58Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+        // Fix the velocity components
+        rNode.Fix(VELOCITY_X);
+        rNode.Fix(VELOCITY_Y);
+        rNode.Fix(VELOCITY_Z);


Not sure if the fixity must be done in here. What if I want to apply this to a problem in which the VELOCITY is not a DOF (e.g. convection).

rubenzorrilla · 2023-10-30T16:01:25Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+        auto& r_point = rNode.GetInitialPosition().Coordinates();
+
+        // Shifting the rotation center to the origin
+        auto centered_point = r_point - rCenterOfRotation;


Same comment. Pass it as a TLS.

rubenzorrilla · 2023-10-30T16:01:40Z

applications/FluidDynamicsApplication/custom_utilities/rotating_frame_utility.cpp

+        auto centered_point = r_point - rCenterOfRotation;
+
+        // Applying the rotation
+        array_1d<double, 3> rotated_point = prod(centered_point, rot_matrix);


Same comment. Pass it as a TLS.

rubenzorrilla · 2023-10-30T16:03:15Z

applications/FluidDynamicsApplication/python_scripts/rotating_frame_process.py

+        # Alternative:
+        # settings.RecursivelyValidateAndAssignDefaults(default_settings)


Suggested change

# Alternative:

# settings.RecursivelyValidateAndAssignDefaults(default_settings)

If not used remove.

rubenzorrilla · 2023-10-30T16:04:59Z

...FluidDynamicsApplication/tests/RotatingFrameProcessTest/RotatingFrameProcessTestResults.json

@@ -0,0 +1,805 @@
+{


Please use snake_case for the subfolder name.

rubenzorrilla · 2023-10-30T16:05:16Z

...ations/FluidDynamicsApplication/tests/RotatingFrameProcessTest/RotatingFrameProcessTest.mdpa

@@ -0,0 +1,214 @@
+Begin ModelPartData


Please use snake_case for the subfolder name.

rubenzorrilla

Shouldn't we put this in the MeshMovingApplication (there's nothing related to fluids in here).

…osMultiphysics/Kratos into Kratos_RotatingFrameProcess

…Kratos_RotatingFrameProcess"

…"origin/Kratos_RotatingFrameProcess"" This reverts commit 5be37fe.

SADPR · 2023-12-20T11:24:12Z

Turning to draft.

SADPR added 9 commits May 17, 2023 18:48

First commit.

599231a

Working in serial (ApplyMeshDispAndRot). Cleaned.

856dc28

Working, only needs last checks, cleans, and tests.

0e60412

Cleaning Python process

ba331e2

Adding MDPA. Maybe clean.

9116422

Results file (JSON). Test.

765b89d

Added test.

6d54988

Cleaned MDPA.

1e59954

Changing name of Model Part

1c4ebe5

SADPR added Enhancement FluidDynamics labels May 19, 2023

SADPR assigned rubenzorrilla May 19, 2023

SADPR requested a review from a team as a code owner May 19, 2023 10:14

loumalouomega reviewed May 19, 2023

View reviewed changes

loumalouomega requested changes May 19, 2023

View reviewed changes

rubenzorrilla reviewed Jun 6, 2023

View reviewed changes

SADPR added 4 commits August 22, 2023 11:01

Assign values using the whole vector

4bf94c2

Assign vector

af0c223

Assign by vector (coordinates).

870a4fc

Pragma once

cec81ab

Last cleaning.

68207b0

Riccardo's suggestion (from another discussion).

3ccb49e

Merge branch 'master' into Kratos_RotatingFrameProcess

44015d6

loumalouomega previously approved these changes Oct 19, 2023

View reviewed changes

Blocking again

94abf9a

loumalouomega dismissed their stale review via 94abf9a October 19, 2023 16:37

rubenzorrilla reviewed Oct 30, 2023

View reviewed changes

SADPR added 2 commits December 5, 2023 15:45

Erase this, is not related to this.!!!!!! I will continue this PR after.

5491777

Merge branch 'Kratos_RotatingFrameProcess' of https://github.com/Krat…

283492f

…osMultiphysics/Kratos into Kratos_RotatingFrameProcess

SADPR requested a review from a team as a code owner December 5, 2023 14:46

SADPR added 2 commits December 5, 2023 20:54

Auto stash before merge of "Kratos_RotatingFrameProcess" and "origin/…

5be37fe

…Kratos_RotatingFrameProcess"

Revert "Auto stash before merge of "Kratos_RotatingFrameProcess" and …

37240f8

…"origin/Kratos_RotatingFrameProcess"" This reverts commit 5be37fe.

SADPR marked this pull request as draft December 20, 2023 11:24

Doing tests on interpolations.

f53cc51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kratos Rotating Frame Process #11158

Kratos Rotating Frame Process #11158

SADPR commented May 19, 2023

loumalouomega commented May 19, 2023

loumalouomega May 19, 2023

SADPR Aug 22, 2023

loumalouomega May 19, 2023 •

edited

Loading

loumalouomega May 19, 2023

loumalouomega May 19, 2023

loumalouomega May 19, 2023 •

edited

Loading

loumalouomega left a comment

rubenzorrilla commented Jun 6, 2023

rubenzorrilla Jun 6, 2023

SADPR Aug 22, 2023

SADPR commented Aug 22, 2023

SADPR commented Aug 22, 2023

SADPR commented Sep 10, 2023

SADPR commented Oct 19, 2023

loumalouomega commented Oct 19, 2023

loumalouomega left a comment

loumalouomega commented Oct 19, 2023

SADPR commented Oct 19, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla Oct 30, 2023

rubenzorrilla left a comment

SADPR commented Dec 20, 2023

		#if !defined(KRATOS_ROTATING_FRAME_UTILITY_H)
		#define KRATOS_ROTATING_FRAME_UTILITY_H

		"rotating_frame_model_part_name": "",
		"rotating_object_model_part_name": "",

		# Alternative:
		# settings.RecursivelyValidateAndAssignDefaults(default_settings)

Kratos Rotating Frame Process #11158

Are you sure you want to change the base?

Kratos Rotating Frame Process #11158

Conversation

SADPR commented May 19, 2023

Overview

Changes Made

loumalouomega commented May 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loumalouomega May 19, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

loumalouomega May 19, 2023 • edited Loading

Choose a reason for hiding this comment

loumalouomega left a comment

Choose a reason for hiding this comment

rubenzorrilla commented Jun 6, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SADPR commented Aug 22, 2023

SADPR commented Aug 22, 2023

SADPR commented Sep 10, 2023

SADPR commented Oct 19, 2023

loumalouomega commented Oct 19, 2023

loumalouomega left a comment

Choose a reason for hiding this comment

loumalouomega commented Oct 19, 2023

SADPR commented Oct 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rubenzorrilla left a comment

Choose a reason for hiding this comment

SADPR commented Dec 20, 2023

loumalouomega May 19, 2023 •

edited

Loading

loumalouomega May 19, 2023 •

edited

Loading