Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GeoMechanicsApplication] Add micro climate condition #11890
[GeoMechanicsApplication] Add micro climate condition #11890
Changes from 118 commits
908c0bb
04ba84a
6c2f4cc
40a701a
d26e80a
e4858bf
87b76fe
23ecf62
cc91081
06e3c08
6757543
29c50f9
c90e443
b3f0f47
f15440c
ec35856
1604345
9d00606
6a594b1
0dbefc3
e95a0fd
56e0f77
124d6de
db184c5
ee9732b
779944f
cafd671
841c4e2
4b44a2a
bcf309d
a085678
ce7db2c
ae7753c
545f01b
6a2c1d7
223facb
fedec1b
e0260f6
57aa1cc
ecaa145
037d53f
30f8ddf
742d9a6
ecf0b68
5cb0788
52a7ba5
7c4b769
08c6565
0028b05
d04b0c0
8bd033d
a6e97de
6e9c36f
ac73980
ce0f5f7
4ad7d2c
b68acdf
f6497e8
8160a16
b81a852
0e6a7c4
238983a
e90ec4b
4c0585f
ed9b20c
a4d5a91
d0d6622
684b370
7694160
77b0224
6db7c26
eff2bd5
6fe5d50
8cfd73a
ec89f45
210985e
e0a23ed
eccff76
f9ad62c
26ceb96
c211cbc
906cd2a
ed40478
7e82f11
c8b90dd
3c6e04e
b479fcc
501f5f1
545a289
03b4f77
9dab74c
33081fa
99d001b
23d5c31
b237215
2abfd1b
fece922
71b8f0b
f9d6b7f
7759759
c52ee8f
f563872
c5cf7bc
d857cdf
bc015cc
2b202aa
0fcfbc6
a5ec227
2284fd6
f22bbe0
68218f1
070cf4f
b67b4ea
3d08ab0
a884b08
9cb81db
bbcc26a
45b13d1
8e3164d
b2c88ea
a8efb38
ad69262
96e4168
4739d67
f8a9bfd
d0df38b
2f46c12
50cb9ae
bdd4195
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wise to have 1 place for definitions.
They seem a mix of material parameters and physical constants. Sadly some of them are redefinitions of already existing parameters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed the redefinition of the water density and as seen in the other comment, the gravity constant is a bigger issue that we'd like to tackle seperately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the 4th redefinition of g that we have ( volumetric acceleration process, weights in waterloads etc. ) It really should be only 1 and 1 alone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completely agreed, however we would like to fix this for all places at once, instead of only for this one (and it's not clear right now where that 1 place would be yet)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentational difference.
Should the registrations always be there or can they be conditional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced a tab with spaces.
I would propose to look at conditional registration of variables in a new issue. I think it is a bit out of scope, since we need to figure out how to do that properly (in a way that it also works for other conditionals)