[GeoMechanicsApplication] gtests #11896
Conversation
# Conflicts: # CMakeLists.txt # kratos/CMakeLists.txt # kratos/includes/global_pointer.h # kratos/mpi/CMakeLists.txt # kratos/mpi/tests/cpp_tests/utilities/test_search_utilities.cpp # kratos/testing/testing.h # kratos/tests/cpp_tests/processes/test_set_initial_state_process.cpp # kratos/tests/test_utilities/test_constitutive_law.cpp # scripts/wheels/linux/configure.sh # scripts/wheels/linux/configure_mpi.sh # scripts/wheels/windows/configure.bat
markelov208
changed the title
|
Hi Mate,
This PR has been created to see changes between different commits. This branch has been created from the old one.
Is it your question on the PR title? Now I have removed 'Draft' from the title and fixed a typo for GeoMechanicsApplication
Thank you.
Kind regards,
Gennady
From: Máté Kelemen ***@***.***>
Sent: maandag 18 december 2023 13:10
To: KratosMultiphysics/Kratos ***@***.***>
Cc: Gennady Markelov ***@***.***>; Assign ***@***.***>
Subject: Re: [KratosMultiphysics/Kratos] Draft [GeoMechanicsAppliation] gtests (PR #11896)
Caution: This message was sent from outside of Deltares. Please do not click links or open attachments unless you recognize the source of this email and know the content is safe. Please report all suspicious emails to ***@***.***" as an attachment.
did you fork off the wrong branch?
-
Reply to this email directly, view it on GitHub<#11896 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BC7NY4K3RZFSKJC2E63M7LTYKAXBBAVCNFSM6AAAAABAZKPDR6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRQGMYTSNBTHA>.
You are receiving this because you were assigned.Message ID: ***@***.***>
DISCLAIMER: This message is intended exclusively for the addressee(s) and may contain confidential and privileged information. If you are not the intended recipient please notify the sender immediately and destroy this message. Unauthorized use, disclosure or copying of this message is strictly prohibited. The foundation 'Stichting Deltares', which has its seat at Delft, The Netherlands, Commercial Registration Number 41146461, is not liable in any way whatsoever for consequences and/or damages resulting from the improper, incomplete and untimely dispatch, receipt and/or content of this e-mail.
|
…le tests with MPI
# Conflicts: # CMakeLists.txt # applications/PfemSolidMechanicsApplication/custom_problemtype/Kratos_Pfem_Solid_Mechanics_Application.gid/002_Kratos_Pfem_Solid_Mechanics_Application_aux.win.bas # docs/pages/Kratos/For_Developers/General/How-to-make-Git-ignore-the-files-resulting-from-a-compilation-without-conflicts-in-.gitignore.md # kratos/python_scripts/testing/run_tests.py # kratos/run_kratos/CMakeLists.txt
- added gtest to CMakeLists.txt - added KRATOS_API(GE_MECHANICS_APPLICATION) - added KRATOS_API(STRUCTURAL_MECHNAICS_APPLICATION) - added KRATOS_API(KRATOS_CORE) - removed KRATOS_API(KRATOS_CORE) - moved scoped_file.* to - added Kratos*FastSuite classes in testing.h - moved test_element.* and test_constitutive_law.* to tests/cpp_tests/utilities - replaced KRATOS_SKIP_TEST_IF_NOT with KRATOS_ERROR_IF_NOT in test_integration_values_extrapolation_to_nodes_process.cpp
- removed running gtest automatically - added TestBarElement manually to KratosCoreTest.exe
- changed libs to lib because libs is deleted - changed KratosStructuralMechanicsTests to KratosStructuralMechanicsTest to be consistent with other executables
CMakeLists.txt
Outdated
| @@ -651,8 +651,8 @@ kratos_python_install(${INSTALL_PYTHON_USING_LINKS} "${KRATOS_SOURCE_DIR}/kratos | |||
| kratos_python_install(${INSTALL_PYTHON_USING_LINKS} "${KRATOS_SOURCE_DIR}/kratos/python_interface/python_registry_utilities.py" "KratosMultiphysics/python_registry_utilities.py" ) | |||
|
|
|||
| # Install the libraries in the libs folder | |||
| install(FILES ${Boost_LIBRARIES} DESTINATION libs) | |||
| install(FILES ${EXTRA_INSTALL_LIBS} DESTINATION libs) | |||
There was a problem hiding this comment.
@markelov208 Please do not change this.
Libs needs to be deleted and repopulated at every compilation to avoid mismatching versions of the same library. This change is intentional.
There was a problem hiding this comment.
@roigcarlo , thank you for letting me know. Currently, the libs folder is populated and then deleted.
[39/40] Install the project...
-- Install configuration: "Debug"
-- Deleting: D:/Checkouts2/KratosProjects/alpha/bin/Debug/KratosMultiphysics
-- Deleting: D:/Checkouts2/KratosProjects/alpha/bin/Debug/libs
Build finished
Please could you let me know how to change the order in cmake file? Thank you.
There was a problem hiding this comment.
The log its a little bit misleading, its the other way around, libs folders gets deleted and then populated if the compilation goes well
There was a problem hiding this comment.
Unfortunately, this is exactly what I have on my laptop: files are copied into libs folder, then libs is deleted. ;) I have reverted libs and put REMOVE_INSTALL_DIRECTORIES OFF.
There was a problem hiding this comment.
Mmm that's quite odd. In any case, its important to maintain the name libs, so if it fails as last resource we can comment the lines that remove the contents of the folder, but changing the name will effectively break the release and RPATH so that cannot be changed
- added geo_testing.h - added structural_testing.h - changed const std::vector<double> to Vector - added KRATOS_ERROR_IN_NOT in test_total_lagrangian_mixed_volumetric_strain_element.cpp - changed KRATOS_ERROR_IF to EXPECT_THAT in expect.h - removed KratosStructural* and KratosGeo* from testing.h
| KRATOS_EXPECT_EQ("Test", "Test"); | ||
| KRATOS_EXPECT_NE("Test ", "Test"); |
There was a problem hiding this comment.
this change does not seem right, should work either way. Can you elaborate please?
There was a problem hiding this comment.
In this branch KRATOS_EXPECT_EQ is replaced with EXPECT_EQ which tests memory allocations for C strings. I guess these two lines were used to check KRATOS_EXPECT_* functionality for C strings. Perhaps, it is better to remove them now.
| std::string WorkingDirectorySellmeijer() | ||
| { | ||
| auto projectDirectory = "./applications/GeoMechanicsApplication/tests/test_compare_sellmeijer/HeightAquiferD10L30.gid"; | ||
| auto kratos_source_directory = std::getenv("KRATOS_SOURCE"); | ||
| return (std::string)kratos_source_directory + "/" + (std::string)projectDirectory; |
There was a problem hiding this comment.
I strongly recommend to use std::filesystem::path for anything related to file paths
There was a problem hiding this comment.
Thank you for pointing. string is replaced with path.
📝 Description
A brief description of the PR.
Please mark the PR with appropriate tags:
🆕 Changelog
Please summarize the changes in one list to generate the changelog:
E.g.