-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename KRATOS_EXPECT_MATRIX_EQUAL
to KRATOS_EXPECT_MATRIX_EQ
#11899
Conversation
@roigcarlo: May I kindly ask you to review this small PR? @loumalouomega: Are these simple changes in line with one of your suggestions for PR #11506? |
I am okay with changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
does GTest have a matrix comparison? |
ping @avdg81 |
@philbucher: As far as I know, GTest doesn't have an |
Adding to @avdg81 answer, it does not have a direct matrix comparison, but it can compare any container that is iterable. The problem is that our matrices are not iterable (or at least it does not like the type of the iterator). For the vectors its already done with iterators: EXPECT_THAT(a, Pointwise(DoubleNear(tolerance), b)); Edit: Also, this works for our |
📝 Description
This PR extracts the changes related to the macro renaming from PR #11506. The aim is to assist in breaking down PR #11506 into smaller pieces that can be reviewed more easily and which can be merged back separately. This commit renames the macro and it updates all of its usages.