[geoMechanicsApplication] extract CalculateFluidPressure function #12381

markelov208 · 2024-05-14T13:19:04Z

📝 Description

CalculateFluidPressure function is placed in transport_equation_utilities as static.
A unit test is added.
Very sorry, retention_law.h is changed with clang format.

avdg81

A small and clear PR that removes several duplicated blocks of code. Thank you so much for the work done here. I have only a few minor suggestions and a question where I would like to have @WPK4FEM 's opinion.

avdg81 · 2024-05-15T11:29:45Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+    N(0) = 1.0;
+    N(1) = 2.0;
+    N(2) = 3.0;
+    N(3) = 4.0;
+    N(4) = 5.0;


I believe these assignments can be simplified by using operator <<= (after including header boost/numeric/ublas/assignment.hpp):

Suggested change

N(0) = 1.0;

N(1) = 2.0;

N(2) = 3.0;

N(3) = 4.0;

N(4) = 5.0;

N <<= 1.0, 2.0, 3.0, 4.0, 5.0;

Many thanks! Copilot was not able to point to the header file.

avdg81 · 2024-05-15T11:31:03Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+    pressure_vector(0) = 0.5;
+    pressure_vector(1) = 0.7;
+    pressure_vector(2) = 0.8;
+    pressure_vector(3) = 0.9;
+    pressure_vector(4) = 0.4;


In the same way, you can simplify these assignments:

Suggested change

pressure_vector(0) = 0.5;

pressure_vector(1) = 0.7;

pressure_vector(2) = 0.8;

pressure_vector(3) = 0.9;

pressure_vector(4) = 0.4;

pressure_vector <<= 0.5, 0.7, 0.8, 0.9, 0.4;

avdg81 · 2024-05-15T11:36:43Z

applications/GeoMechanicsApplication/custom_retention/retention_law.h

@@ -84,20 +82,19 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) RetentionLaw {
            return mFluidPressure.value();
        }

-        const ProcessInfo& GetProcessInfo() const
+        [[nodiscard]] static double CalculateFluidPressure(const Vector& rN, const Vector& rPressureVector)


I fully agree with the idea to move this functionality to a single location, rather than it being scattered across several elements (as it used to be). I doubt, however, whether this nested class is the best possible location. Perhaps we should consult @WPK4FEM. I can imagine that class GeoElementUtilities might be a good alternative. What do you think gentlemen?

I think we discussed it briefly. Otherwise I would place the function in transport_..._utilities. GeoElementUtilities includes a lot of various functions right now. @WPK4FEM , what is your opinion?

Computing an interpolated value of a nodal variable uses the interpolation polynomials. These belong to the element and not to constitutive laws nor to retention laws. Therefore GeoElementUtilities sounds like a good place. utilities for retention laws or constitutive models is a bad place. Transport Equation utilities is also a good place, because it handles element matrices for the water pressure part.

As interpolation by definition is the inner product or shape functions and nodal variables, just writing inner_prod is fine. Naming this operation specifically for the water pressures is better, because the name of the function is explaining what the intention is.

Thank you for the detailed answer. The function has been moved to transport_equation_utilities.

avdg81 · 2024-05-15T11:39:57Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

+            Variables.FluidPressure =
+                RetentionLaw::Parameters::CalculateFluidPressure(Variables.Np, Variables.PressureVector);


I have fixed the missing assignment a few minutes ago on master by merging one of my pending PRs. Please update this branch by merging master into it (you will probably need to a resolve a merge conflict, since we have touched the same lines).

You are right there were merge conflicts.

# Conflicts: # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.hpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_interface_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_interface_element.hpp # applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp # applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.hpp

markelov208

Anne, thank you for the comments.

markelov208 · 2024-05-15T12:22:06Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

+            Variables.FluidPressure =
+                RetentionLaw::Parameters::CalculateFluidPressure(Variables.Np, Variables.PressureVector);


You are right there were merge conflicts.

markelov208 · 2024-05-15T12:26:13Z

applications/GeoMechanicsApplication/custom_retention/retention_law.h

@@ -84,20 +82,19 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) RetentionLaw {
            return mFluidPressure.value();
        }

-        const ProcessInfo& GetProcessInfo() const
+        [[nodiscard]] static double CalculateFluidPressure(const Vector& rN, const Vector& rPressureVector)


I think we discussed it briefly. Otherwise I would place the function in transport_..._utilities. GeoElementUtilities includes a lot of various functions right now. @WPK4FEM , what is your opinion?

markelov208 · 2024-05-15T12:27:34Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+    N(0) = 1.0;
+    N(1) = 2.0;
+    N(2) = 3.0;
+    N(3) = 4.0;
+    N(4) = 5.0;


Many thanks! Copilot was not able to point to the header file.

markelov208 · 2024-05-15T12:27:42Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+    pressure_vector(0) = 0.5;
+    pressure_vector(1) = 0.7;
+    pressure_vector(2) = 0.8;
+    pressure_vector(3) = 0.9;
+    pressure_vector(4) = 0.4;


WPK4FEM · 2024-05-15T12:35:57Z

applications/GeoMechanicsApplication/custom_retention/retention_law.h

@@ -84,20 +82,19 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) RetentionLaw {
            return mFluidPressure.value();
        }

-        const ProcessInfo& GetProcessInfo() const
+        [[nodiscard]] static double CalculateFluidPressure(const Vector& rN, const Vector& rPressureVector)


Computing an interpolated value of a nodal variable uses the interpolation polynomials. These belong to the element and not to constitutive laws nor to retention laws. Therefore GeoElementUtilities sounds like a good place. utilities for retention laws or constitutive models is a bad place. Transport Equation utilities is also a good place, because it handles element matrices for the water pressure part.

As interpolation by definition is the inner product or shape functions and nodal variables, just writing inner_prod is fine. Naming this operation specifically for the water pressures is better, because the name of the function is explaining what the intention is.

WPK4FEM · 2024-05-15T12:42:31Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+KRATOS_TEST_CASE_IN_SUITE(CalculateFluidPressureGivesCorrectResults, KratosGeoMechanicsFastSuite)
+{
+    Vector N(5);
+    N <<= 1.0, 2.0, 3.0, 4.0, 5.0;


For an real interpolation function based on 5 nodes, these values are strange. However, for testing they are fine.

It is just for testing. Put something into and to get this later back.

No need to change.

markelov208

Wijtse-Pieter, many thanks.

markelov208 · 2024-05-15T13:21:01Z

applications/GeoMechanicsApplication/custom_retention/retention_law.h

@@ -84,20 +82,19 @@ class KRATOS_API(GEO_MECHANICS_APPLICATION) RetentionLaw {
            return mFluidPressure.value();
        }

-        const ProcessInfo& GetProcessInfo() const
+        [[nodiscard]] static double CalculateFluidPressure(const Vector& rN, const Vector& rPressureVector)


Thank you for the detailed answer. The function has been moved to transport_equation_utilities.

markelov208 · 2024-05-15T13:21:43Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+KRATOS_TEST_CASE_IN_SUITE(CalculateFluidPressureGivesCorrectResults, KratosGeoMechanicsFastSuite)
+{
+    Vector N(5);
+    N <<= 1.0, 2.0, 3.0, 4.0, 5.0;


It is just for testing. Put something into and to get this later back.

WPK4FEM

Good to go for me.

WPK4FEM · 2024-05-15T13:50:14Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_fluid_pressure.cpp

+KRATOS_TEST_CASE_IN_SUITE(CalculateFluidPressureGivesCorrectResults, KratosGeoMechanicsFastSuite)
+{
+    Vector N(5);
+    N <<= 1.0, 2.0, 3.0, 4.0, 5.0;


No need to change.

extracted CalculateFluidPressure function

5be8639

markelov208 self-assigned this May 14, 2024

markelov208 linked an issue May 14, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Stiffness Matrix (K) #12371

Closed

markelov208 requested review from rfaasse and avdg81 May 14, 2024 17:52

avdg81 reviewed May 15, 2024

View reviewed changes

Gennady Markelov added 2 commits May 15, 2024 14:09

used ublas assigment

dd7040b

markelov208 commented May 15, 2024

View reviewed changes

WPK4FEM reviewed May 15, 2024

View reviewed changes

moved CalculateFluidPressure function to transport_equation_utilities

1f6eea2

markelov208 commented May 15, 2024

View reviewed changes

fixed a call of CalculateFixedPressure

1bbad67

markelov208 requested review from WPK4FEM and avdg81 May 15, 2024 13:43

WPK4FEM approved these changes May 15, 2024

View reviewed changes

markelov208 merged commit 9364c39 into master May 16, 2024
11 checks passed

markelov208 deleted the geo/extract-calculate-fluid-pressure branch May 16, 2024 07:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[geoMechanicsApplication] extract CalculateFluidPressure function #12381

[geoMechanicsApplication] extract CalculateFluidPressure function #12381

markelov208 commented May 14, 2024 •

edited

Loading

avdg81 left a comment

avdg81 May 15, 2024

markelov208 May 15, 2024

avdg81 May 15, 2024

markelov208 May 15, 2024

avdg81 May 15, 2024

markelov208 May 15, 2024

WPK4FEM May 15, 2024

markelov208 May 15, 2024

avdg81 May 15, 2024

markelov208 May 15, 2024

markelov208 left a comment

markelov208 May 15, 2024

markelov208 May 15, 2024

markelov208 May 15, 2024

markelov208 May 15, 2024

WPK4FEM May 15, 2024

WPK4FEM May 15, 2024

markelov208 May 15, 2024

WPK4FEM May 15, 2024

markelov208 left a comment

markelov208 May 15, 2024

markelov208 May 15, 2024

WPK4FEM left a comment

WPK4FEM May 15, 2024

		Variables.FluidPressure =
		RetentionLaw::Parameters::CalculateFluidPressure(Variables.Np, Variables.PressureVector);

[geoMechanicsApplication] extract CalculateFluidPressure function #12381

[geoMechanicsApplication] extract CalculateFluidPressure function #12381

Conversation

markelov208 commented May 14, 2024 • edited Loading

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WPK4FEM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 commented May 14, 2024 •

edited

Loading