[GeoMechanicsApplication] extract SetConstitutiveParameters function #12382

markelov208 · 2024-05-14T14:51:29Z

📝 Description

SetConstitutiveParameters function is moved to ConstitutiveLawUtilities
A unit test is added.

…or small_strain_U_Pw_diff_order_element and U_Pw_small_strain_element

…for the rest of elements

rfaasse · 2024-05-15T11:35:58Z

@markelov208 This looks like a very useful PR. However, it will give quite some merge conflicts with my current attempt to extract the constitutive matrix. Could we wait with merging this one until that has gone back (since you are also waiting for that one for the stiffness matrix)?

markelov208 · 2024-05-15T11:40:21Z

@markelov208 This looks like a very useful PR. However, it will give quite some merge conflicts with my current attempt to extract the constitutive matrix. Could we wait with merging this one until that has gone back (since you are also waiting for that one for the stiffness matrix)?

Sure, we can wait.

avdg81

Yet another PR that cleans up our code. What I like most about this PR is that the new interface is explicit about which parameters will be set, rather than giving it a data structure without knowing which members will be used. As before, I only have a few minor suggestions.

avdg81 · 2024-05-15T14:31:59Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_constitutive_law_set6.cpp

+    strain_vector(0)           = 1.0;
+    strain_vector(1)           = 2.0;
+    strain_vector(2)           = 3.0;


As for the other PR I have reviewed today, I would suggest to use the concise notation for assigning values to a vector (after including boost/numeric/ublas/assignment.hpp):

Suggested change

strain_vector(0) = 1.0;

strain_vector(1) = 2.0;

strain_vector(2) = 3.0;

strain_vector <<= 1.0, 2.0, 3.0;

Thank you. fixed

avdg81 · 2024-05-15T14:32:53Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_constitutive_law_set6.cpp

+    N(0)                                         = 0.1;
+    N(1)                                         = 0.2;
+    N(2)                                         = 0.5;


And a similar change here:

Suggested change

N(0) = 0.1;

N(1) = 0.2;

N(2) = 0.5;

N <<= 0.1, 0.2, 0.5;

avdg81 · 2024-05-15T14:35:58Z

applications/GeoMechanicsApplication/custom_utilities/constitutive_law_utilities.hpp

@@ -24,6 +25,14 @@ class ConstitutiveLawUtilities
 public:
    static int GetStateVariableIndex(const Variable<double>& rThisVariable);

+    static void SetSixMechanicsConstitutiveParameters(ConstitutiveLaw::Parameters& rConstitutiveParameters,


Perhaps a name like SetConstitutiveParameters will also do?

Restored the old title. Agreed that the new title is not more informative.

# Conflicts: # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.hpp

# Conflicts: # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_FIC_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_interface_element.hpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_FIC_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_element.cpp # applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp # applications/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.cpp

markelov208 · 2024-05-16T14:15:31Z

@rfaasse , it looks that these changes are not needed any more due to your recent PR. Correct?

rfaasse

Thanks a lot for extracting this function, again removing duplication!

It clashed a bit with the previous PR (sorry for the merge conflicts), but that also means that quite a few of the function calls are not necessary anymore after that commit. When looking at this PR, we only need to retain the places where previously this->SetConstitutiveParameters(Variables, ConstitutiveParameters); was called (right now we see that there are quite some lines added with respect to master).

Also we can use your new function in the CalculateAnyOfMaterialResponse function to make it shorter (both for diff order and non-diff order).

Please let me know if this is unclear (which I can imagine, because very specifically related to what I just merged).

rfaasse · 2024-05-16T14:13:01Z

applications/GeoMechanicsApplication/tests/cpp_tests/test_constitutive_law_set6.cpp

Clear unit test! To reflect the name of the file it tests, we could also rename it to test_constitutive_law_utilities.cpp

rfaasse · 2024-05-16T14:14:37Z

applications/GeoMechanicsApplication/custom_utilities/constitutive_law_utilities.cpp

@@ -26,4 +26,19 @@ int ConstitutiveLawUtilities::GetStateVariableIndex(const Variable<double>& rThi
    return index - 1;
 }

+void ConstitutiveLawUtilities::SetConstitutiveParameters(ConstitutiveLaw::Parameters& rConstitutiveParameters,


Very nice addition. I think it could also be used in the CalculateAnyOfMaterialResponse functions in the diff order and non-diff order elements!

Thank you for pointing. Added there.

rfaasse · 2024-05-16T14:16:07Z

...tions/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.cpp

+        ConstitutiveLawUtilities::SetConstitutiveParameters(
+            ConstitutiveParameters, Variables.StrainVector, Variables.ConstitutiveMatrix,
+            Variables.Nu, Variables.DNu_DX, Variables.F, Variables.detF);


This function call is no longer necessary, since the constitutive matrices are already calculated (they are only retrieved here from the vector).

rfaasse · 2024-05-16T14:16:21Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

@@ -1353,6 +1363,9 @@ void SmallStrainUPwDiffOrderElement::CalculateMaterialStiffnessMatrix(MatrixType
        Variables.F                  = deformation_gradients[GPoint];
        Variables.StrainVector       = strain_vectors[GPoint];
        Variables.ConstitutiveMatrix = constitutive_matrices[GPoint];
+        ConstitutiveLawUtilities::SetConstitutiveParameters(


This function call is no longer necessary, since the constitutive matrices are already calculated (they are only retrieved here from the vector).

rfaasse · 2024-05-16T14:18:16Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_FIC_element.cpp

@@ -152,6 +153,9 @@ void UPwSmallStrainFICElement<TDim, TNumNodes>::InitializeNonLinearIteration(con
        Variables.B                  = b_matrices[GPoint];
        Variables.F                  = deformation_gradients[GPoint];
        Variables.ConstitutiveMatrix = constitutive_matrices[GPoint];
+        ConstitutiveLawUtilities::SetConstitutiveParameters(


This function call is no longer necessary, since the constitutive matrices are already calculated (they are only retrieved here from the vector). I think there will be only a few places left now after the changes of the PR for the lists of constitutive matrices. Basically everywhere we retrieve the Constitutive Matrix from a list (i.e. Variables.ConstitutiveMatrix = constitutive_matrices[GPoint];) we don't need this call anymore. I think it will be there in ~3 places for diff order and ~3 places for non-diff order.

Thank you. Removed in many places. But not all calls. ;)

rfaasse · 2024-05-16T14:19:08Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

@@ -169,8 +170,9 @@ void UPwSmallStrainElement<TDim, TNumNodes>::InitializeSolutionStep(const Proces
        Variables.detF         = determinants_of_deformation_gradients[GPoint];
        Variables.StrainVector = strain_vectors[GPoint];

-        // Set Gauss points variables to constitutive law parameters
-        this->SetConstitutiveParameters(Variables, ConstitutiveParameters);
+        ConstitutiveLawUtilities::SetConstitutiveParameters(


This call we need to retain, because the constitutive matrix was not calculated before the loop

rfaasse · 2024-05-16T14:19:31Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

@@ -268,6 +270,9 @@ void UPwSmallStrainElement<TDim, TNumNodes>::InitializeNonLinearIteration(const
    this->CalculateAnyOfMaterialResponse(deformation_gradients, ConstitutiveParameters,
                                         Variables.NContainer, Variables.DN_DXContainer,
                                         strain_vectors, mStressVector, constitutive_matrices);
+        ConstitutiveLawUtilities::SetConstitutiveParameters(


This we can also remove, because we already called CalculateAnyOfMaterialResponse

…ulateAnyOfMaterialResponse

avdg81

I have no further comments. I believe this is ready to go. Thanks for the hard work Gennady!

Gennady Markelov added 2 commits May 14, 2024 16:12

replaced SetConstitutiveParameters with SetSixConsitituveParameters f…

d3e8619

…or small_strain_U_Pw_diff_order_element and U_Pw_small_strain_element

replaced SetConstitutiveParameters with SetSixConstitutiveParameters …

69ed65c

…for the rest of elements

markelov208 requested a review from a team as a code owner May 14, 2024 14:51

markelov208 self-assigned this May 14, 2024

markelov208 linked an issue May 14, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Stiffness Matrix (K) #12371

Closed

added unit test

ac78a56

markelov208 requested review from avdg81 and rfaasse and removed request for a team, avdg81 and rfaasse May 14, 2024 19:13

Gennady Markelov added 2 commits May 14, 2024 21:54

moved SetSixConstitutiveParameters to constitutive_law_utilities

5afd2b5

revert constitutive_law.h

da7efa4

markelov208 requested review from rfaasse and avdg81 May 14, 2024 21:41

avdg81 reviewed May 15, 2024

View reviewed changes

Gennady Markelov added 2 commits May 15, 2024 17:04

restored SetConstitutiveParameters name

4fc57b8

Merge branch 'master' into geo/extract-set-constitutive-parameters

a4cec35

# Conflicts: # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.hpp

markelov208 requested a review from avdg81 May 16, 2024 07:26

rfaasse reviewed May 16, 2024

View reviewed changes

Gennady Markelov added 3 commits May 16, 2024 17:30

removed call SetConstitutiveParameters when settings are done in Calc…

0e75b3c

…ulateAnyOfMaterialResponse

removed redundant includes on constitutive_law_utilities.hpp

7717dc0

used SetConstitutiveParameters in CalculateAnyOfMaterialResponse

ce42098

markelov208 requested a review from rfaasse May 17, 2024 09:41

avdg81 approved these changes May 17, 2024

View reviewed changes

markelov208 merged commit 4b60023 into master May 17, 2024
11 checks passed

markelov208 deleted the geo/extract-set-constitutive-parameters branch May 17, 2024 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] extract SetConstitutiveParameters function #12382

[GeoMechanicsApplication] extract SetConstitutiveParameters function #12382

markelov208 commented May 14, 2024 •

edited

Loading

rfaasse commented May 15, 2024

markelov208 commented May 15, 2024

avdg81 left a comment

avdg81 May 15, 2024

markelov208 May 15, 2024

avdg81 May 15, 2024

markelov208 May 15, 2024

avdg81 May 15, 2024

markelov208 May 15, 2024 •

edited

Loading

markelov208 commented May 16, 2024

rfaasse left a comment

rfaasse May 16, 2024

rfaasse May 16, 2024

markelov208 May 16, 2024 •

edited

Loading

rfaasse May 16, 2024

markelov208 May 16, 2024

rfaasse May 16, 2024

markelov208 May 16, 2024

rfaasse May 16, 2024

markelov208 May 16, 2024

rfaasse May 16, 2024

markelov208 May 16, 2024

rfaasse May 16, 2024

markelov208 May 16, 2024

avdg81 left a comment

[GeoMechanicsApplication] extract SetConstitutiveParameters function #12382

[GeoMechanicsApplication] extract SetConstitutiveParameters function #12382

Conversation

markelov208 commented May 14, 2024 • edited Loading

rfaasse commented May 15, 2024

markelov208 commented May 15, 2024

avdg81 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 May 15, 2024 • edited Loading

Choose a reason for hiding this comment

markelov208 commented May 16, 2024

rfaasse left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 May 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

markelov208 commented May 14, 2024 •

edited

Loading

markelov208 May 15, 2024 •

edited

Loading

markelov208 May 16, 2024 •

edited

Loading