[GeoMechanicsApplication] Calculate strains #12385
Conversation
markelov208
requested review from
rfaasse,
WPK4FEM and
avdg81
and removed request for
WPK4FEM
# Conflicts: # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.hpp
There was a problem hiding this comment.
Thank you for taking this up, it removes a lot of duplication. I think there is a small discussion point left about how much we will actually move to the utilities for this PR and about unit testing now that the function is moved. I don't want to block the PR (since I'm not there tomorrow), so feel free to discuss tomorrow with Anne/Wijtze Pieter and merge after!
| Vector StressStrainUtilities::CalculateCauchyStrain(const Matrix& rB, const Vector& rDisplacements) | ||
| { | ||
| return prod(rB, rDisplacements); | ||
| } |
There was a problem hiding this comment.
Very nice we moved this one and removed the duplication in the elements. Now that it's here and the function itself is relatively straight-forward: could we add a unit test?
There was a problem hiding this comment.
Unit tests are added for CalculateStrains and CalculateCauchyStrain.
| std::vector<Vector> StressStrainUtilities::CalculateStrains(const std::vector<Matrix>& rDeformationGradients, | ||
| const std::vector<Matrix>& rBs, | ||
| const Vector& rDisplacements, | ||
| bool UseHenckyStrain, | ||
| std::size_t VoigtSize) | ||
| { | ||
| std::vector<Vector> result; | ||
| std::transform( | ||
| rDeformationGradients.begin(), rDeformationGradients.end(), rBs.begin(), std::back_inserter(result), | ||
| [&rDisplacements, UseHenckyStrain, VoigtSize](const auto& rDeformationGradient, const auto& rB) { | ||
| return UseHenckyStrain ? CalculateHenckyStrain(rDeformationGradient, VoigtSize) | ||
| : CalculateCauchyStrain(rB, rDisplacements); | ||
| }); | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
I'm still not too sure if the stress strain utilities should be responsible of choosing which strain measure to calculate based on a flag (also since we only provide two possibilities here, while there are other possibilities in this file e.g. VonMisesStrain). I was probably a bit ambiguous during our discussion. Maybe it's good to double check this with @WPK4FEM and @avdg81?
I do agree that we put the choice directly in the transform instead of as a separate function though.
There was a problem hiding this comment.
I discussed a related question with @WPK4FEM to use both CalculateStrains and CalculateAnyOfMaterialResponse at the same time. He has suggested to keep it now.
There was a problem hiding this comment.
To not delay this PR, let's keep it the way it is for now. We may want to revisit this functionality later when we'd like to add support for more strain measures.
# Conflicts: # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_FIC_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_FIC_element.cpp # applications/GeoMechanicsApplication/custom_elements/U_Pw_updated_lagrangian_element.cpp # applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp # applications/GeoMechanicsApplication/custom_elements/updated_lagrangian_U_Pw_diff_order_element.cpp
| Vector StressStrainUtilities::CalculateCauchyStrain(const Matrix& rB, const Vector& rDisplacements) | ||
| { | ||
| return prod(rB, rDisplacements); | ||
| } |
There was a problem hiding this comment.
Unit tests are added for CalculateStrains and CalculateCauchyStrain.
| std::vector<Vector> StressStrainUtilities::CalculateStrains(const std::vector<Matrix>& rDeformationGradients, | ||
| const std::vector<Matrix>& rBs, | ||
| const Vector& rDisplacements, | ||
| bool UseHenckyStrain, | ||
| std::size_t VoigtSize) | ||
| { | ||
| std::vector<Vector> result; | ||
| std::transform( | ||
| rDeformationGradients.begin(), rDeformationGradients.end(), rBs.begin(), std::back_inserter(result), | ||
| [&rDisplacements, UseHenckyStrain, VoigtSize](const auto& rDeformationGradient, const auto& rB) { | ||
| return UseHenckyStrain ? CalculateHenckyStrain(rDeformationGradient, VoigtSize) | ||
| : CalculateCauchyStrain(rB, rDisplacements); | ||
| }); | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
I discussed a related question with @WPK4FEM to use both CalculateStrains and CalculateAnyOfMaterialResponse at the same time. He has suggested to keep it now.
| std::vector<Vector> StressStrainUtilities::CalculateStrains(const std::vector<Matrix>& rDeformationGradients, | ||
| const std::vector<Matrix>& rBs, | ||
| const Vector& rDisplacements, | ||
| bool UseHenckyStrain, | ||
| std::size_t VoigtSize) | ||
| { | ||
| std::vector<Vector> result; | ||
| std::transform( | ||
| rDeformationGradients.begin(), rDeformationGradients.end(), rBs.begin(), std::back_inserter(result), | ||
| [&rDisplacements, UseHenckyStrain, VoigtSize](const auto& rDeformationGradient, const auto& rB) { | ||
| return UseHenckyStrain ? CalculateHenckyStrain(rDeformationGradient, VoigtSize) | ||
| : CalculateCauchyStrain(rB, rDisplacements); | ||
| }); | ||
|
|
||
| return result; | ||
| } |
There was a problem hiding this comment.
To not delay this PR, let's keep it the way it is for now. We may want to revisit this functionality later when we'd like to add support for more strain measures.
📝 Description