[GeoMechanicsApplication] extract stiffness matrix utility #12388

markelov208 · 2024-05-17T10:47:43Z

📝 Description

Calculation of stiffness matrix is extracted as utility functions
CalculateStiffnessMatrixGPoint provides the matrix for a specific integration point because some functions like CalculateAndAddLHS still work on this level
CalculateStiffnessMatrix provides the matrix on the element level
the function is documented and unit tested.

avdg81

Thanks for extracting the calculation of the stiffness matrix to a utility function. It is a bit unfortunate that we still need to have this calculation at two levels: element level (final goal) and integration point level. However, after examining your code I understand why that is needed. As far as I can see this was the best you could do for now (considering that we'd like to keep PRs small enough to be manageable), so well done! What I like in particular is that some duplication has been removed. Much better! I only have a few minor remarks, nothing major or blocking.

avdg81 · 2024-05-17T14:35:16Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

-
-    // Distribute stiffness block matrix into the elemental matrix
-    GeoElementUtilities::AssembleUUBlockMatrix(rLeftHandSideMatrix, rVariables.UUMatrix);
+    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(


Suggested change

Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(

const auto stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(

avdg81 · 2024-05-17T14:38:43Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

The comment at line 1334 no longer makes sense. Please remove it.

avdg81 · 2024-05-17T14:39:51Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

-    Matrix StiffnessMatrix =
-        prod(trans(rVariables.B), Matrix(prod(rVariables.ConstitutiveMatrix, rVariables.B))) *
-        rVariables.IntegrationCoefficient;
+    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(


Suggested change

Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(

const auto stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(

avdg81 · 2024-05-17T14:42:10Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

-        prod(trans(rVariables.B), Matrix(prod(rVariables.ConstitutiveMatrix, rVariables.B))) *
-        rVariables.IntegrationCoefficient;
+    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
+        rVariables.B, rVariables.ConstitutiveMatrix, rVariables.IntegrationCoefficient);

    // Distribute stiffness block matrix into the elemental matrix


Also here, you could remove this redundant comment (like you did for the small strain element).

avdg81 · 2024-05-17T14:45:54Z

applications/GeoMechanicsApplication/custom_utilities/README.md

 -  CalculateMassMatrix function
+-  CalculateStiffnessMatrixGPoint provides a stiffness matrix for a specific integration point
+-  CalculateStiffnessMatrix provides a stiffness matrix for all integration points


Perhaps rephrase this, to emphasize that this function works on element level?

Suggested change

- CalculateStiffnessMatrix provides a stiffness matrix for all integration points

- CalculateStiffnessMatrix provides a stiffness matrix for an element

Actually, it was my first option but then I made it like others. ;( Changed.

avdg81 · 2024-05-17T14:51:14Z

applications/GeoMechanicsApplication/custom_utilities/equation_of_motion_utilities.h

+    static Matrix CalculateStiffnessMatrix(const std::vector<Matrix>& b_matrices,
+                                           const std::vector<Matrix>& constitutive_matrices,
+                                           const std::vector<double>& integration_coefficients);


To comply with the KratosStyle Guide, we need to rename the parameters as follows:

Suggested change

static Matrix CalculateStiffnessMatrix(const std::vector<Matrix>& b_matrices,

const std::vector<Matrix>& constitutive_matrices,

const std::vector<double>& integration_coefficients);

static Matrix CalculateStiffnessMatrix(const std::vector<Matrix>& rBMatrices,

const std::vector<Matrix>& rConstitutiveMatrices,

const std::vector<double>& rIntegrationCoefficients);

markelov208

Anne, many thanks for the sharp eyes. ;)

markelov208 · 2024-05-17T15:10:53Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

markelov208 · 2024-05-17T15:14:34Z

applications/GeoMechanicsApplication/custom_elements/U_Pw_small_strain_element.cpp

-
-    // Distribute stiffness block matrix into the elemental matrix
-    GeoElementUtilities::AssembleUUBlockMatrix(rLeftHandSideMatrix, rVariables.UUMatrix);
+    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(


markelov208 · 2024-05-17T15:14:43Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

-    Matrix StiffnessMatrix =
-        prod(trans(rVariables.B), Matrix(prod(rVariables.ConstitutiveMatrix, rVariables.B))) *
-        rVariables.IntegrationCoefficient;
+    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(


markelov208 · 2024-05-17T15:14:56Z

applications/GeoMechanicsApplication/custom_elements/small_strain_U_Pw_diff_order_element.cpp

-        prod(trans(rVariables.B), Matrix(prod(rVariables.ConstitutiveMatrix, rVariables.B))) *
-        rVariables.IntegrationCoefficient;
+    Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
+        rVariables.B, rVariables.ConstitutiveMatrix, rVariables.IntegrationCoefficient);

    // Distribute stiffness block matrix into the elemental matrix


markelov208 · 2024-05-17T15:15:33Z

applications/GeoMechanicsApplication/custom_utilities/README.md

 -  CalculateMassMatrix function
+-  CalculateStiffnessMatrixGPoint provides a stiffness matrix for a specific integration point
+-  CalculateStiffnessMatrix provides a stiffness matrix for all integration points


Actually, it was my first option but then I made it like others. ;( Changed.

markelov208 · 2024-05-17T15:15:43Z

applications/GeoMechanicsApplication/custom_utilities/equation_of_motion_utilities.h

+    static Matrix CalculateStiffnessMatrix(const std::vector<Matrix>& b_matrices,
+                                           const std::vector<Matrix>& constitutive_matrices,
+                                           const std::vector<double>& integration_coefficients);


avdg81

I think this one is ready to go.

Gennady Markelov added 2 commits May 17, 2024 10:26

used integration_coefficients

891206f

added CalculateStiffnessMatrix on element level

8affcf9

markelov208 self-assigned this May 17, 2024

Gennady Markelov added 2 commits May 17, 2024 13:09

removed commented lines

20643a9

removed unused NumGPoints

e4240e8

markelov208 linked an issue May 17, 2024 that may be closed by this pull request

[GeoMechanicsApplication] Extract a static utility function for the calculation of the Stiffness Matrix (K) #12371

Closed

Gennady Markelov added 4 commits May 17, 2024 14:13

used const reference for integration coefficients

d6d4686

added description of stiffness matrix

931901e

added unit test for CalculateStiffnessMatrix

845a373

added const to ElementVariables in CalculateAndAddStiffnessMatrix

ff1b41a

markelov208 requested review from rfaasse, WPK4FEM and avdg81 May 17, 2024 13:41

avdg81 reviewed May 17, 2024

View reviewed changes

changed following the review comments

f52e0c1

markelov208 commented May 17, 2024

View reviewed changes

avdg81 approved these changes May 17, 2024

View reviewed changes

markelov208 enabled auto-merge May 17, 2024 15:21

markelov208 merged commit 328250d into master May 17, 2024
11 checks passed

markelov208 deleted the geo/12371-extract-stiffness-matrix-utility branch May 17, 2024 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GeoMechanicsApplication] extract stiffness matrix utility #12388

[GeoMechanicsApplication] extract stiffness matrix utility #12388

markelov208 commented May 17, 2024 •

edited

Loading

avdg81 left a comment •

edited

Loading

avdg81 May 17, 2024

markelov208 May 17, 2024

avdg81 May 17, 2024

markelov208 May 17, 2024

avdg81 May 17, 2024

markelov208 May 17, 2024

avdg81 May 17, 2024

markelov208 May 17, 2024

avdg81 May 17, 2024

markelov208 May 17, 2024

avdg81 May 17, 2024

markelov208 May 17, 2024

markelov208 left a comment

markelov208 May 17, 2024

markelov208 May 17, 2024

markelov208 May 17, 2024

markelov208 May 17, 2024

markelov208 May 17, 2024

markelov208 May 17, 2024

avdg81 left a comment

	Matrix stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(
	const auto stiffness_matrix = GeoEquationOfMotionUtilities::CalculateStiffnessMatrixGPoint(

	- CalculateStiffnessMatrix provides a stiffness matrix for all integration points
	- CalculateStiffnessMatrix provides a stiffness matrix for an element

[GeoMechanicsApplication] extract stiffness matrix utility #12388

[GeoMechanicsApplication] extract stiffness matrix utility #12388

Conversation

markelov208 commented May 17, 2024 • edited Loading

avdg81 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markelov208 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

avdg81 left a comment

Choose a reason for hiding this comment

markelov208 commented May 17, 2024 •

edited

Loading

avdg81 left a comment •

edited

Loading