Geo/check number of tables phreatic multi line #12689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfaasse
reviewed
Sep 26, 2024
...echanicsApplication/custom_processes/apply_constant_phreatic_multi_line_pressure_process.cpp
Show resolved
Hide resolved
...nicsApplication/tests/cpp_tests/test_apply_constant_phreatic_multi_line_pressure_process.cpp
Outdated
Show resolved
Hide resolved
...echanicsApplication/custom_processes/apply_constant_phreatic_multi_line_pressure_process.cpp
Show resolved
Hide resolved
...chanicsApplication/tests/cpp_tests/test_apply_phreatic_multi_line_pressure_table_process.cpp
Outdated
Show resolved
Hide resolved
...nicsApplication/tests/cpp_tests/test_apply_constant_phreatic_multi_line_pressure_process.cpp
Show resolved
Hide resolved
rfaasse
approved these changes
Oct 25, 2024
|
FYI We need to bring it up to date with master before we can merge (due to the failing windows pipeline being fixed) |
WPK4FEM
force-pushed
the
geo/check_number_of_tables_phreatic_multi_line
branch
from
8adbf56 to
2d7186b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
To make sure that the number of tables matches the number of points of the multlinear phreatic line input a check has been added.
🆕 Changelog