Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[StructApp] Adapting the StructuralMechanicsBossak scheme to rototational dofs #12869

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

JonasHill
Copy link

📝 Description
Current situation:
The current implementation of StructuralMechanicsBossakScheme does not update the angular time derivatives ANGULAR_VELOCITY and ANGULAR_ACCELERATION.

This PR adapts the StructuralMechanicsBossakScheme to allow transient simulations of structures containing elements with rotational dofs. Therefore the methods Predict, Update and InitializeSolutionStep are extended. The extended implementations are analogous to those of the base methods in the ResidualBasedBossakDisplacementScheme, whereby the corresponding degrees of freedom are replaced by their angular counterparts.

🆕 Changelog

  • Added StructuralMechanicsBossakScheme::Update method to update ANGULAR_VELOCITY and ANGULAR_ACCELERATION dofs
  • Added StructuralMechanicsBossakScheme::Predict method to predict the ROTATION dof
  • Adapted StructuralMechanicsBossakScheme::InitializeSolutionStep method to fix the dofs consistently

@JonasHill JonasHill requested a review from a team as a code owner November 26, 2024 11:47
Comment on lines 150 to 151
if(rModelPart.HasNodalSolutionStepVariable(ROTATION))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(rModelPart.HasNodalSolutionStepVariable(ROTATION))
{
if(rModelPart.HasNodalSolutionStepVariable(ROTATION)) {

Comment on lines 238 to 239
if(rModelPart.HasNodalSolutionStepVariable(ROTATION))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(rModelPart.HasNodalSolutionStepVariable(ROTATION))
{
if(rModelPart.HasNodalSolutionStepVariable(ROTATION)) {

KRATOS_CATCH("")
}

void Update(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doxygen

@@ -122,21 +130,191 @@ class StructuralMechanicsBossakScheme
}
}

void Predict(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doxygen

Comment on lines 272 to 273
if(rModelPart.HasNodalSolutionStepVariable(ROTATION))
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if(rModelPart.HasNodalSolutionStepVariable(ROTATION))
{
if(rModelPart.HasNodalSolutionStepVariable(ROTATION)) {

Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments

@JonasHill JonasHill added Applications C++ Behaviour Change changes behaviour but not the API labels Nov 26, 2024
@AlejandroCornejo
Copy link
Member

@RiccardoRossi FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications Behaviour Change changes behaviour but not the API C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants