Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Adding Rocky image build to CI #12887

Merged
merged 13 commits into from
Dec 17, 2024
Merged

[CI] Adding Rocky image build to CI #12887

merged 13 commits into from
Dec 17, 2024

Conversation

loumalouomega
Copy link
Member

📝 Description

Adding Rocky image build to CI

🆕 Changelog

@loumalouomega loumalouomega added Compilation FastPR This Pr is simple and / or has been already tested and the revision should be fast Continuous Integration related to Travis, Appveyor, ... labels Nov 29, 2024
@loumalouomega loumalouomega requested a review from a team as a code owner November 29, 2024 07:55
roigcarlo
roigcarlo reviewed Nov 29, 2024
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 But wait approval until I build the image and we can test it pls 🙏

@loumalouomega
Copy link
Member Author

Ci is broken :P

@roigcarlo
Copy link
Member

#12891

@loumalouomega loumalouomega requested a review from a team as a code owner December 2, 2024 11:08
@loumalouomega
Copy link
Member Author

What is the status of this @roigcarlo ?

@roigcarlo
Copy link
Member

On it, its top of the list but still didn't have time.

@loumalouomega
Copy link
Member Author

Huum, Centos Ci is still there?

@roigcarlo
Copy link
Member

mm odd, let me see

@roigcarlo
Copy link
Member

Yep the one governing the Centos build is unchanges, you modified the workflow that autobuilds de CI image

@loumalouomega
Copy link
Member Author

Yep the one governing the Centos build is unchanges, you modified the workflow that autobuilds de CI image

ah, sorry

@loumalouomega
Copy link
Member Author

@roigcarlo I just realized that in our installations Boost is installed manually so I installed in the DokerFile the boost as well, for the moment in order to check that the Rocky image works in the other PR I will manually download the boost, but eventually we should update the image (IMO)

@roigcarlo
Copy link
Member

With #12936 merged we can close this one right?

@loumalouomega
Copy link
Member Author

With #12936 merged we can close this one right?

Nope, #12937 can be closed, but this one is to build the Image

roigcarlo
roigcarlo approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, anyway sees that win is failing, I just set it to rerun, seems fault of MPM

@loumalouomega loumalouomega merged commit 1a76a15 into master Dec 17, 2024
11 checks passed
@loumalouomega loumalouomega deleted the ci/update-docker-rocky-image branch December 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roigcarlo roigcarlo roigcarlo approved these changes

Assignees
No one assigned
Labels
Compilation Continuous Integration related to Travis, Appveyor, ... FastPR This Pr is simple and / or has been already tested and the revision should be fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loumalouomega @roigcarlo @AlejandroCornejo