[Fluid] Weakly compressible darcy relative velocity #12889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiccardoRossi
previously approved these changes
Nov 29, 2024
|
@jgonzalezusua note that I required to rename the variable also in your solver. I think this one is more convenient as we are now using this list to also add non material-related variables. |
|
@RiccardoRossi should be ready now. |
RiccardoRossi
approved these changes
Dec 3, 2024
rubenzorrilla
deleted the
fluid/weakly-compressible-darcy-relative-velocity
branch
|
Sorry for the late response... I agree with the changes in my solver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Adding the solid fraction velocity to the Darcy term calculation. The changes in the solver are to avoid misunderstandings with the variable lists names (these are not only material variables).
@RiccardoRossi here you can find a tiny example on how to use it (see the MainKratos.py).
EDIT: note that I took the chance to correct a tiny error in the Darcy part of the stabilization constants.