Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LinearSolversApplication] Reactivating MKL with Clang, because apparently now it compiles again #12901

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[LinearSolversApplication] Reactivating MKL with Clang, because apparently now it compiles again #12901

merged 1 commit into from
Dec 4, 2024

Conversation

loumalouomega
Copy link
Member

📝 Description

Reactivating MKL with Clang, because apparently now it compiles again

🆕 Changelog

@loumalouomega loumalouomega added Applications Clang External library Compilation FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Dec 4, 2024
@loumalouomega loumalouomega requested review from a team as code owners December 4, 2024 14:58
roigcarlo
roigcarlo approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice

philbucher
philbucher reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@philbucher philbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure it was a runtime and not a compiletime problem

Did you test it?

@loumalouomega
Copy link
Member Author

Pretty sure it was a runtime and not a compiletime problem

Did you test it?

Yes, I tested

@loumalouomega
Copy link
Member Author

Pretty sure it was a runtime and not a compiletime problem

Did you test it?

Yes, it was runtime, I tested

@loumalouomega loumalouomega merged commit 3445e3e into master Dec 4, 2024
10 of 11 checks passed
@loumalouomega loumalouomega deleted the linearsolvers/apparently-now-is-possible-to-compile-with-mkl-so-reactivating-this-name-branch-is-too-long-hola-mama branch December 4, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philbucher philbucher philbucher left review comments

@roigcarlo roigcarlo roigcarlo approved these changes

Assignees
No one assigned
Labels
Applications Clang Compilation External library FastPR This Pr is simple and / or has been already tested and the revision should be fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loumalouomega @roigcarlo @philbucher