Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fluid] Move BlockSize to data containers #12938

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

rubenzorrilla
Copy link
Member

📝 Description
In this PR I'm moving the BlockSize static constexpr variable from the FluidElement base class to the data containers. This will make possible to use current element inheritance structure with formulations featuring unknowns different to u-p (e.g., thermally coupled ones). Also note that I took the chance to move the data containers from custom_utilities folder to the data_containers one together to the element.

@jgonzalezusua note that you had an error in the block size definition in your DEM coupled element. As far is I see you were not using that one but the one from the base element. In any case, take this observation into account just in case.

@uxuech note that this will affect your new elements when merging the master (you need to do the corresponding changes mimicking the ones in here in your branch).

@jgonzalezusua
Copy link
Member

jgonzalezusua commented Dec 12, 2024

Thanks for fixing the error, it was just a small mistake. I did not used that variable.

@rubenzorrilla
Copy link
Member Author

Thanks for fixing the error, it was just a small mistake. I did not used that variable.

Yes. It was silently there, the point is that with this change it woke up 😄 . Nevertheless, just for you to know.

@rubenzorrilla
Copy link
Member Author

Note that last bunch of commits only remove the redundant custom_elements/ from the includes.

RiccardoRossi
RiccardoRossi previously approved these changes Dec 13, 2024
@rubenzorrilla rubenzorrilla force-pushed the fluid/move-block-size-to-data-containers branch from 6f11bdb to b0013b8 Compare December 13, 2024 09:30
@rubenzorrilla rubenzorrilla merged commit 2d3672d into master Dec 13, 2024
10 of 11 checks passed
@rubenzorrilla rubenzorrilla deleted the fluid/move-block-size-to-data-containers branch December 13, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants