-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PfemFluid] Add constitutive laws #6504
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MZecchetto
added
Applications
Refactor
When code is moved or rewrote keeping the same behavior
labels
Mar 3, 2020
AFranci
previously approved these changes
Mar 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MZecchetto! very good job!
MZecchetto
force-pushed
the
PfemFluid/add-constitutive-laws
branch
from
May 4, 2020 07:02
3df67a3
to
2ff8f27
Compare
AFranci
approved these changes
May 4, 2020
sorry |
MZecchetto
added a commit
that referenced
this pull request
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first stage of the pfem elements restyling.
Basically the computation of the stresses and the effective viscosity of the fluids are now managed by the constitutive laws. This also allows an easier implementation of the temperature dependent material properties (refer to KratosMultiphysics/GiDInterface#713).
Aside the tests, all the constitutive laws are checked against the current behaviour in the master branch. Performance test is also successful.
@GuillermoCasas , @joaquinirazabal SDEM-PFEM test and example are update accordingly.
@jginternational temperature dependent constitutive laws will follow shortly in a separate PR.
Massimiliano