[Core] Define projection geometry threshold #7364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@philbucher Mapping app is failing, I don't understand as I keep the current tolerances in order to not break code. |
Ping @philbucher |
|
Aside from the failing tests I have some serious concerns both regarding the code design as well as the performance |
|
@loumalouomega as @RiccardoRossi suggesed in the other thread, may be use can make a different function the bin_based_fast_point_locator to use the project functions and not IsInside function ? |
|
see #7401 |
|
Closing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7337. This PR adds to the IsInside method a projection threshold. In order to not consider projection at all must be defined as 0.0. Is defined 0.0 by default except for the geometries already considering projection, in order to not break current tests/implementations.
Changelog