Add Pfem Melting application #9324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ysics/Kratos into meltingapplication Conflicts: applications/PfemMeltingApplication/custom_utilities/streamline.h
…ysics/Kratos into meltingapplication
…ysics/Kratos into meltingapplication
…ysics/Kratos into meltingapplication
…ysics/Kratos into meltingapplication
…ysics/Kratos into meltingapplication
maceligueta
reviewed
Feb 2, 2022
| @@ -85,7 +85,7 @@ namespace Kratos | |||
|
|
|||
| //node_it->FastGetSolutionStepValue(ARRHENIUS_VALUE)=aux_var_polymer; | |||
|
|
|||
| node_it->FastGetSolutionStepValue(HEAT_FLUX) = (-1.0) * density * heat_of_vaporization * aux_var_polymer; | |||
| node_it->FastGetSolutionStepValue(HEAT_FLUX) = 0.0 * (-1.0) * density * heat_of_vaporization * aux_var_polymer; | |||
There was a problem hiding this comment.
is this temporary? Maybe we can put just
node_it->FastGetSolutionStepValue(HEAT_FLUX) = 0.0;
|
Hi, it is temporary.
El mié, 2 feb 2022 a las 16:00, Miguel Angel Celigueta (<
***@***.***>) escribió:
… ***@***.**** commented on this pull request.
------------------------------
In applications/PfemMeltingApplication/custom_utilities/heat_source.h
<#9324 (comment)>
:
> @@ -85,7 +85,7 @@ namespace Kratos
//node_it->FastGetSolutionStepValue(ARRHENIUS_VALUE)=aux_var_polymer;
- node_it->FastGetSolutionStepValue(HEAT_FLUX) = (-1.0) * density * heat_of_vaporization * aux_var_polymer;
+ node_it->FastGetSolutionStepValue(HEAT_FLUX) = 0.0 * (-1.0) * density * heat_of_vaporization * aux_var_polymer;
is this temporary? Maybe we can put just
node_it->FastGetSolutionStepValue(HEAT_FLUX) = 0.0;
—
Reply to this email directly, view it on GitHub
<#9324 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AGHII5FLTMLG2UQO33K4O7LUZFBKNANCNFSM5H2EQVCA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds the PFEM melting application to Kratos.
I'm setting this as a draft PR in order to discuss some of the changes
🆕 Changelog
@maceligueta @juliobarna