Skip to content

Commit

Permalink
Semi complete discussion on PR preview limits
Browse files Browse the repository at this point in the history
Aimed at an internal audience, but hits most of the main points and will need to be updated before merging upstream.
  • Loading branch information
KrystalDelusion committed Jul 18, 2024
1 parent 1f9b015 commit 2cacd1f
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 1 deletion.
1 change: 1 addition & 0 deletions docs/source/appendix.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Appendix
:maxdepth: 2
:includehidden:

appendix/building_docs
appendix/primer
appendix/auxlibs
appendix/auxprogs
Expand Down
34 changes: 34 additions & 0 deletions docs/source/appendix/building_docs.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
Building the documentation
==========================

A portion of the documentation is generated dynamically by using Yosys during
the build process.

More stuff here.

PR previews and limitations
---------------------------

Because we are building from the Yosys repo, we can preview PRs (like this
one!).

As described above, some of the content in the documentation is generated
dynamically. While this has the benefit of always staying up-to-date with the
latest version of Yosys (including any local changes you might make), it does
mean that some parts of the documentation will be missing when using the Read
the Docs PR preview feature. This includes most images that are generated from
:cmd:ref:`show`, some other images that are built from ``.tex`` source, as well
as all of the :doc:`/cmd_ref` and the upcoming cell reference.

`YosysHQ/Yosys#4376`_ adds a step to the test docs action which not only
attempts to build the docs with the Yosys build being tested, but it will also
then upload artifacts for both the pdf and html builds. If the PR being
(p)reviewed changes this generated content then it is possible to download these
artifacts to check the Sphinx output (see: the corresponding `action run`_ from
the PR referenced, although the artifacts for it are expired and no longer
available). Note that the current version in that PR only builds Yosys without
Verific, if documentation changes for Yosys+Verific are expected then it would
be reasonably straight-forward to update `test-verific.yml` instead.

.. _YosysHQ/Yosys#4376: https://github.com/YosysHQ/yosys/pull/4376
.. _action run: https://github.com/YosysHQ/yosys/actions/runs/9246974933
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@
rtds_action_github_token = os.environ["GITHUB_TOKEN"]
else:
# We're on read the docs but have no github token, this is probably a PR preview build
html_theme_options["announcement"] = "<strong>Oh no!</strong> This looks like a ReadTheDocs build, possibly for a PR preview, that's missing some generated content!"
html_theme_options["announcement"] = 'Missing content? Check <a class="reference internal" href="https://tyrtd--2.org.readthedocs.build/en/2/appendix/building_docs.html#limitations">PR preview limitations</a>.'
html_theme_options["light_css_variables"]["color-announcement-background"] = "var(--color-admonition-title-background--caution)"
html_theme_options["light_css_variables"]["color-announcement-text"] = "var(--color-content-foreground)"

Expand Down

0 comments on commit 2cacd1f

Please sign in to comment.