Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Tracing Sampling Strategy Rules #96

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

david-martin
Copy link
Member

@david-martin david-martin commented Jul 9, 2024

This RFC is an attempt to capture the thoughts and considerations around the bullet item 'Look into adding "well-known" fields into our span to "trace" them back to the user's domain: RLP, AP, …' from #48

The body of work described in the doc is post v1 milestone. Priority & scheduling TBD.

TODO:

  • Get answers to unresolved questions & update the doc accordingly
  • Investigate 'prior art'

@david-martin david-martin requested a review from alexsnaps July 9, 2024 10:31
@david-martin david-martin mentioned this pull request Jul 9, 2024
7 tasks
@alexsnaps alexsnaps added the RFC Request For Comments label Aug 20, 2024
@Boomatang
Copy link
Contributor

As this would be configured inside the kuadrant CR, it would be worth looking at #112 as it is trying to define a standardized API design for new features added to the kuadrant CR

@alexsnaps
Copy link
Member

Wrt to the prior art, you might want to look into head- vs. tail-based sampling in tracing. But I'm somewhat confused about two main use cases:

  • Error (somewhere late in the game something "fails", which that would need definition already - an exception/panic/err would be already complicated bu what about e.g. "too slow" request) and as a user I'd certainly would want to have that trace available
  • Enabling tracing on a "late in the game known attribute", e.g. trace for user bob, how would limitador know that pre-auth ratelimiting phase would need to send traces for ... bob that we'd only know about in the auth phase?

I think this tries to resolve tail-based sampling... If so, do we want to do that? Now that being said, there is still much more we can do to be a better citizen in that space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants