Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid conflict with the VERSION build arg #217

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

guicassolato
Copy link
Collaborator

Use a different name for the VERSION build arg in the Dockerfile, to avoid conflict with env vars set at the base image.

❯ docker run --rm -ti registry.access.redhat.com/ubi9/go-toolset:1.21 /bin/bash
bash-5.1$ echo ${VERSION}
1.21.13

@guicassolato guicassolato self-assigned this Oct 3, 2024
@guicassolato guicassolato requested a review from eguzki October 3, 2024 08:12
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.78%. Comparing base (b9f6460) to head (98e962a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   61.78%   61.78%           
=======================================
  Files           2        2           
  Lines         785      785           
=======================================
  Hits          485      485           
  Misses        249      249           
  Partials       51       51           
Flag Coverage Δ
unit 61.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guicassolato guicassolato merged commit 0e972a4 into main Oct 3, 2024
12 checks passed
@guicassolato guicassolato deleted the version-build-arg branch October 3, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants